Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stabilize QUIC tests on server 2022 #65057

Merged
merged 1 commit into from
Feb 9, 2022
Merged

stabilize QUIC tests on server 2022 #65057

merged 1 commit into from
Feb 9, 2022

Conversation

wfurt
Copy link
Member

@wfurt wfurt commented Feb 9, 2022

contributes to #64944.

The reason why the test hangs is simple. We put Debug.Assert to retry loop but (to collect dump on final failure) but that does nothing on Release builds. We will move on to await on accept task that but that will never finish since the connect failed.

In debug build this is failing 100% for me so as one more test for client certificates. It is not clear at this point if this is limitation of schanell on 2022 or some issue in our code or msquic.

I'm disabling two offending tests to get pass for both release and debug flavor.

@wfurt wfurt added test-bug Problem in test source code (most likely) area-System.Net.Quic labels Feb 9, 2022
@wfurt wfurt requested a review from a team February 9, 2022 06:18
@wfurt wfurt self-assigned this Feb 9, 2022
@ghost
Copy link

ghost commented Feb 9, 2022

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

contributes to #64944.

The reason why the test hangs is simple. We put Debug.Assert to retry loop but (to collect dump on final failure) but that does nothing on Release builds. We will move on to await on accept task that but that will never finish since the connect failed.

In debug build this is failing 100% for me so as one more test for client certificates. It is not clear at this point if this is limitation of schanell on 2022 or some issue in our code or msquic.

I'm disabling two offending tests to get pass for both release and debug flavor.

Author: wfurt
Assignees: wfurt
Labels:

test bug, area-System.Net.Quic

Milestone: -

Copy link
Member

@CarnaViire CarnaViire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wfurt
Copy link
Member Author

wfurt commented Feb 9, 2022

/backport to release/6.0

@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2022

Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1820035057

@karelz karelz added this to the 7.0.0 milestone Feb 22, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Mar 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Net.Quic test-bug Problem in test source code (most likely)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants