Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Account for HWI stores in LIR side effects code #65079

Merged
merged 3 commits into from
Feb 9, 2022
Merged

Account for HWI stores in LIR side effects code #65079

merged 3 commits into from
Feb 9, 2022

Conversation

SingleAccretion
Copy link
Contributor

@SingleAccretion SingleAccretion commented Feb 9, 2022 •
edited
Loading

We must do so for correctness.

Also added an assert to catch unhanded cases like these in the future.

No diffs as expected.

@SingleAccretion
Add a test
cd0b365
@SingleAccretion
Account for HWI stores in LIR side effect code
6448bea 
Otherwise we risk missing stores to addressable locations.
@SingleAccretion
Add MEMORYBARRIER to fix the assert
bc55349 
Won't ever matter as memory barriers split statements.
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Feb 9, 2022
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Feb 9, 2022
@ghost
Copy link

ghost commented Feb 9, 2022

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

We must do so for correctness.

No diffs are expected.

Author: SingleAccretion
Assignees: -
Labels:

area-CodeGen-coreclr, community-contribution
Milestone: -

@SingleAccretion SingleAccretion marked this pull request as ready for review February 9, 2022 19:02
@SingleAccretion
Copy link
Contributor Author

Linux arm64 failure is #46175 (comment) (will assume not related).

@dotnet/jit-contrib

AndyAyersMS
AndyAyersMS approved these changes Feb 9, 2022
View reviewed changes
Copy link
Member

@AndyAyersMS AndyAyersMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

This is the same thing you pointed me to the other day, right? I tried turning that snippet into a failing test but failed.

@SingleAccretion
Copy link
Contributor Author

This is the same thing you pointed me to the other day, right?

Hmm, don't know if that was it or not. I did mention it once, I suppose.

@AndyAyersMS AndyAyersMS merged commit 99452b2 into dotnet:main Feb 9, 2022
@SingleAccretion SingleAccretion deleted the Fix-HWI-Store-Interf-Checks branch February 10, 2022 09:09
@JulieLeeMSFT JulieLeeMSFT mentioned this pull request Mar 3, 2022
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Mar 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AndyAyersMS AndyAyersMS AndyAyersMS approved these changes

Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SingleAccretion @AndyAyersMS