[mono][workload] Add workloads for win-arm64 using emulation #65089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should do the same for android and iOS |
done, I added a win-arm64 alias everywhere we had a win-x64 alias |
lewing
changed the title
| @@ -166,6 +166,7 @@ | |||
| "version": "${PackageVersion}", | |||
| "alias-to": { | |||
| "win-x64": "Microsoft.NETCore.App.Runtime.AOT.win-x64.Cross.android-x86", | |||
| "win-arm64": "Microsoft.NETCore.App.Runtime.AOT.win-x64.Cross.android-x86", | |||
There was a problem hiding this comment.
@Redth when you're testing win-arm64, can you validate if this .exe runs:
> "C:\Program Files\dotnet\packs\Microsoft.NETCore.App.Runtime.AOT.win-x64.Cross.android-x86\6.0.2-mauipre.1.22074.5\tools\mono-aot-cross.exe"
If it prints help output, I think that means it would work.
|
Draft Pull Request was automatically closed for inactivity. Please let us know if you'd like to reopen it. |
steveisok
approved these changes
Mar 24, 2022
steveisok
pushed a commit
that referenced
this pull request
Mar 25, 2022
radekdoulik
pushed a commit
to radekdoulik/runtime
that referenced
this pull request
Mar 30, 2022
…65089) * Add wasm workload for win-arm64 using emulation * Add aliases for win-arm64 to all the win-x64 cases as well (android, ios)
radekdoulik
pushed a commit
to radekdoulik/runtime
that referenced
this pull request
Mar 30, 2022
…otnet#65089)" (dotnet#67154) This reverts commit 4e7ccfa.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pairs with dotnet/emsdk#109 and would be a workaround until we have native builds of the tooling. I don't have a way to test this so we'll need some manual checks to verify.