Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stack overflow tests to accept 800703E9 exit code too #65331

Merged
merged 1 commit into from
Feb 15, 2022

Conversation

janvorli
Copy link
Member

Sometimes a process failing with stack overflow returns exit code
0x800703e9 (ERROR_STACK_OVERFLOW). This change updates the stack
overflow test to accept that code too.

Sometimes a process failing with stack overflow returns exit code
0x800703e9 (ERROR_STACK_OVERFLOW). This change updates the stack
overflow test to accept that code too.
Console.WriteLine($"Exit code: 0x{testProcess.ExitCode:X8}, expected 0x{expectedExitCode:X8}");
string separator = string.Empty;
StringBuilder expectedListBuilder = new StringBuilder();
Array.ForEach(expectedExitCodes, code => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a test so I assume we don't care about code size

@janvorli
Copy link
Member Author

The installer test failure is unrelated to this change. It is a SIGSEGV crash, however there are no artifacts (logs, dumps) available for further analysis.
It just shows "Unable to Load Helix Data" (see https://dev.azure.com/dnceng/public/_build/results?buildId=1612130&view=ms.vss-test-web.build-test-results-tab&runId=44895492&resultId=100381&paneView=dotnet-dnceng.dnceng-anon-build-release-tasks.helix-anon-test-information-tab). @dotnet/dnceng is that something you are aware of?

@janvorli janvorli merged commit ec965b5 into dotnet:main Feb 15, 2022
@lpatalas
Copy link

@janvorli I'm not sure if this is some known issue but I will ask around. @MattGal do you know anything about it?

As a workaround you can also get to the artifacts from the build page. I think this one relates to the failed test.

@lpatalas
Copy link

I think the issue is that the tests do not run in Helix but directly on the build machine. That's why that tab says "Unable to load Helix data". We have an issue to improve the message here: https://github.com/dotnet/core-eng/issues/13862.

@janvorli
Copy link
Member Author

@lpatalas thank you for the details!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants