Add partial to the enclosing types when running the ConvertToGeneratedDllImport fixer #65452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the same node while also touching their own change) and add tests.
jkoritzinsky
added
area-System.Runtime.InteropServices
source-generator
ghost
assigned 
|
Tagging subscribers to this area: @dotnet/interop-contrib Issue DetailsFixes #62291
|
jkoritzinsky
changed the title
|
System.IO.Tests failures are in multiple PRs. Tracked in #65791 |
AaronRobinsonMSFT
approved these changes
Mar 4, 2022
....InteropServices/gen/LibraryImportGenerator/Analyzers/ConvertToGeneratedDllImportAnalyzer.cs
Outdated
Show resolved
Hide resolved
...ime.InteropServices/gen/LibraryImportGenerator/Analyzers/ConvertToGeneratedDllImportFixer.cs
Outdated
Show resolved
Hide resolved
elinor-fung
reviewed
Mar 7, 2022
| Microsoft Visual Studio Solution File, Format Version 12.00 | ||
| # Visual Studio Version 17 | ||
| VisualStudioVersion = 17.2.32211.407 | ||
| MinimumVisualStudioVersion = 10.0.40219.1 |
There was a problem hiding this comment.
I assume VS did this? Do we try to keep the .sln files slngen edits only?
There was a problem hiding this comment.
Generally we try to keep the sln files such that they don't generate diffs when you open them in VS, but that usually depends on slngen generating them perfectly and sometimes it doesn't do it quite right.
elinor-fung
approved these changes
Mar 7, 2022
....Runtime.InteropServices/gen/LibraryImportGenerator/Analyzers/ConvertToLibraryImportFixer.cs
Outdated
Show resolved
Hide resolved
...e.InteropServices/tests/LibraryImportGenerator.UnitTests/ConvertToLibraryImportFixerTests.cs
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also includes some refactoring to make it easier to write the custom fix all provider that was required.
Fixes #62291