Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove or move some expensive low-value testing #65453

Merged
merged 2 commits into from
Feb 17, 2022

Conversation

agocke
Copy link
Member

@agocke agocke commented Feb 16, 2022

There are two sets of runs we do right now that aren't very valuable.

Single-file is mainly testing API compatiblity and the analyzer has mostly solved that. NativeAOT also now verifies this.

PGO is still important, but very stable and only needs to run in the official runs during publishing.

When PGO was added, I added it in PR as well just to help with monitoring
At this point it's very stable and expensive to run, so we should probably move it out.
Single-file is still tested in our unit tests, but these runs were mainly to test the
compatibility of APIs with single-file. We've found that the analyzer does a pretty good
job of verifying that without testing, and we still have verification via NativeAOT, which
I think is a superset of the testing as a whole.
@ghost
Copy link

ghost commented Feb 16, 2022

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

There are two sets of runs we do right now that aren't very valuable.

Single-file is mainly testing API compatiblity and the analyzer has mostly solved that. NativeAOT also now verifies this.

PGO is still important, but very stable and only needs to run in the official runs during publishing.

Author: agocke
Assignees: agocke
Labels:

area-Infrastructure-libraries

Milestone: -

@agocke agocke requested review from safern and a team February 16, 2022 20:29
@ghost
Copy link

ghost commented Feb 17, 2022

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

There are two sets of runs we do right now that aren't very valuable.

Single-file is mainly testing API compatiblity and the analyzer has mostly solved that. NativeAOT also now verifies this.

PGO is still important, but very stable and only needs to run in the official runs during publishing.

Author: agocke
Assignees: agocke
Labels:

area-Infrastructure

Milestone: -

@agocke agocke merged commit f29ba20 into dotnet:main Feb 17, 2022
@agocke agocke deleted the pgo-in-official branch February 17, 2022 01:19
@safern
Copy link
Member

safern commented Feb 17, 2022

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants