Skip to content

Always build ref pack even in servicing releases #65579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2022

Conversation

safern
Copy link
Member

@safern safern commented Feb 18, 2022

This was already done in release/6.0 branch, this is just making sure we have it in main so that in future servicing branches this is already taken care of.

@ghost
Copy link

ghost commented Feb 18, 2022

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost assigned safern Feb 18, 2022
Copy link
Member

@jkoritzinsky jkoritzinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If similar work has been completed in dotnet/windowsdesktop, we should consider removing the ProjectServicingConfiguration feature from the SharedFramework SDK as there will be no users of it.

@ghost
Copy link

ghost commented Feb 18, 2022

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

This was already done in release/6.0 branch, this is just making sure we have it in main so that in future servicing branches this is already taken care of.

Author: safern
Assignees: safern
Labels:

area-Infrastructure

Milestone: -

@safern
Copy link
Member Author

safern commented Feb 18, 2022

If similar work has been completed in dotnet/windowsdesktop, we should consider removing the ProjectServicingConfiguration feature from the SharedFramework SDK as there will be no users of it.

@RussKie can you confirm this was the case?

@RussKie
Copy link
Contributor

RussKie commented Feb 21, 2022

Yes, addressed in dotnet/windowsdesktop#2571.
And dotnet/windowsdesktop#2633.

@akoeplinger akoeplinger merged commit cb5e1c4 into dotnet:main Feb 21, 2022
@akoeplinger
Copy link
Member

If similar work has been completed in dotnet/windowsdesktop, we should consider removing the ProjectServicingConfiguration feature from the SharedFramework SDK as there will be no users of it.

@jkoritzinsky it looks like it is still used by https://github.com/dotnet/deployment-tools/blob/097b01d7091fdf281144b4e22a5ff6245ea7cf04/eng/Versions.props#L46-L50

@safern safern deleted the AlwaysBuildRefPack branch February 21, 2022 15:13
@jkoritzinsky
Copy link
Member

That looks like it was copied straight from the old dotnet/core-setup repo and might be dead, but I’ll make sure before doing anything.

@ghost ghost locked as resolved and limited conversation to collaborators Mar 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants