Add CentOS Stream 9 to the helix matrix #65785
Conversation
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
ghost
added
the
community-contribution
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue Detailsnull
|
omajid
force-pushed
the
ci-add-centos-stream-9
branch
from
b4d89ba
to
6548b69
Compare
|
A ton of errors are due to: Not sure what's setting up this |
|
Hm. It's odd - it's supposed to come from here: https://github.com/dotnet/dotnet-buildtools-prereqs-docker/blob/b5e98ffda0465be7c51b562a97fecaae3fa32527/src/centos/stream9/Dockerfile#L43 |
|
Ah. CentOS Stream 9/RHEL 9's |
|
Not easily - those are autogenerated by helix. Maybe installing the symlink in the image feels like an easier thing? The scripts are python3 based, so that should be fairly transparent. |
|
Sounds good. I was afraid it might be assuming |
Helix needs it. So, might as we install it. See dotnet/runtime#65785
Needed for runtime, eg dotnet/runtime#65785
| - RedHat.7.Amd64.Open | ||
| - ${{ if eq(variables['System.TeamProject'], 'internal') }}: | ||
| - (Debian.10.Amd64)Ubuntu.1804.amd64@mcr.microsoft.com/dotnet-buildtools/prereqs:debian-10-helix-amd64-20210304164434-56c6673 | ||
| - (Debian.11.Amd64)Ubuntu.1804.amd64@mcr.microsoft.com/dotnet-buildtools/prereqs:debian-11-helix-amd64-20210304164428-5a7c380 | ||
| - Ubuntu.1804.Amd64 | ||
| - (Centos.8.Amd64)Ubuntu.1604.amd64@mcr.microsoft.com/dotnet-buildtools/prereqs:centos-8-helix-20201229003624-c1bf759 | ||
| - (Centos.Stream9.Amd64.Open)Ubuntu.1804.Amd64.Open@mcr.microsoft.com/dotnet-buildtools/prereqs:centos-stream9-20220107135047-4cd394c |
There was a problem hiding this comment.
| - (Centos.Stream9.Amd64.Open)Ubuntu.1804.Amd64.Open@mcr.microsoft.com/dotnet-buildtools/prereqs:centos-stream9-20220107135047-4cd394c | |
| - (Centos.Stream9.Amd64)Ubuntu.1804.Amd64@mcr.microsoft.com/dotnet-buildtools/prereqs:centos-stream9-20220107135047-4cd394c |
| @@ -62,6 +62,7 @@ jobs: | |||
| - ${{ if and(eq(parameters.jobParameters.interpreter, ''), ne(parameters.jobParameters.isSingleFile, true)) }}: | |||
| - ${{ if and(eq(parameters.jobParameters.testScope, 'outerloop'), eq(parameters.jobParameters.runtimeFlavor, 'mono')) }}: | |||
| - (Centos.8.Amd64.Open)Ubuntu.1804.Amd64.Open@mcr.microsoft.com/dotnet-buildtools/prereqs:centos-8-helix-20201229003624-c1bf759 | |||
| - (Centos.Stream9.Amd64.Open)Ubuntu.1804.Amd64.Open@mcr.microsoft.com/dotnet-buildtools/prereqs:centos-stream9-20220107135047-4cd394c | |||
There was a problem hiding this comment.
I'd have to check, but there should be a place to add these in non-open queues so they can be tested against security releases.
| @@ -89,17 +89,20 @@ jobs: | |||
| - ${{ if eq(parameters.platform, 'Linux_x64') }}: | |||
| - ${{ if and(eq(variables['System.TeamProject'], 'public'), in(parameters.jobParameters.helixQueueGroup, 'pr', 'ci', 'libraries')) }}: | |||
| - Ubuntu.1804.Amd64.Open | |||
| - (Centos.Stream9.Amd64.Open)Ubuntu.1804.Amd64.Open@mcr.microsoft.com/dotnet-buildtools/prereqs:centos-stream9-20220107135047-4cd394c | |||
There was a problem hiding this comment.
This would also duplicate testing on every PR. We usually do horizontal deployment into the platform matrix in our outer loop testing (that being said, I feel like there's nothing running tests on those other queues right now...)
Needed for runtime, eg dotnet/runtime#65785
Needed for runtime, eg dotnet/runtime#65785
Needed for runtime, eg dotnet/runtime#65785
omajid
force-pushed
the
ci-add-centos-stream-9
branch
from
6548b69
to
86c292d
Compare
ghost
closed this
|
Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it. |
ghost
locked as resolved and limited conversation to collaborators
No description provided.