-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix nullability mismatch between ref
and src
in Microsoft.Extensions.Caching.Abstractions
#65804
Conversation
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
PostEvictionDelegate
between ref
and src
ref
and src
in Microsoft.Extensions.Caching.Abstractions
It's on the backlog, but not yet funded. We would need:
To be fixed first. For now, be sure to run GenerateReferenceSource in your PRs that change the nullable annotations. FYI @ericstj. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your quick response on this @maxkoshevoi!
LGTM
But running |
Tagging subscribers to this area: @dotnet/area-extensions-caching Issue DetailsI missed a spot in #64018 Somehow,
|
This should if you have a built the library already. If you have a project where this isn't working let us know and I'll take a quick look. -- Actually file an issue so we don't lose it -- area-infrastucture-libraries. |
I missed a spot in #64018
Somehow,
PostEvictionDelegate
andCacheExtensions
were annotated differently inref
andscr
.@eerhardt CI might need some improvement to catch those issues (if
ref
projects are not removed)