Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nullability mismatch between ref and src in Microsoft.Extensions.Caching.Abstractions #65804

Merged
merged 2 commits into from
Feb 24, 2022

Conversation

maxkoshevoi
Copy link
Contributor

@maxkoshevoi maxkoshevoi commented Feb 23, 2022

I missed a spot in #64018

Somehow, PostEvictionDelegate and CacheExtensions were annotated differently in ref and scr.
@eerhardt CI might need some improvement to catch those issues (if ref projects are not removed)

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Feb 23, 2022
@maxkoshevoi maxkoshevoi changed the title Fix nullability mismatch in PostEvictionDelegate between ref and src Fix nullability mismatch between ref and src in Microsoft.Extensions.Caching.Abstractions Feb 23, 2022
@eerhardt
Copy link
Member

@eerhardt CI might need some improvement to catch those issues (if ref projects are not removed)

It's on the backlog, but not yet funded. We would need:

To be fixed first. For now, be sure to run GenerateReferenceSource in your PRs that change the nullable annotations.

FYI @ericstj.

Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your quick response on this @maxkoshevoi!

LGTM

@maxkoshevoi
Copy link
Contributor Author

be sure to run GenerateReferenceSource in your PRs that change the nullable annotations.

But running dotnet msbuild /t:GenerateReferenceAssemblySource doesn't update nullable annotations for me.. (at least it didn't a month ago)

@ghost
Copy link

ghost commented Feb 23, 2022

Tagging subscribers to this area: @dotnet/area-extensions-caching
See info in area-owners.md if you want to be subscribed.

Issue Details

I missed a spot in #64018

Somehow, PostEvictionDelegate and CacheExtensions were annotated differently in ref and scr.
@eerhardt CI might need some improvement to catch those issues (if ref projects are not removed)

Author: maxkoshevoi
Assignees: eerhardt
Labels:

area-Extensions-Caching, community-contribution

Milestone: -

@stephentoub stephentoub merged commit 56c9cd9 into dotnet:main Feb 24, 2022
@ericstj
Copy link
Member

ericstj commented Feb 28, 2022

But running dotnet msbuild /t:GenerateReferenceAssemblySource doesn't update nullable annotations for me.. (at least it didn't a month ago)

This should if you have a built the library already. If you have a project where this isn't working let us know and I'll take a quick look. -- Actually file an issue so we don't lose it -- area-infrastucture-libraries.

@maxkoshevoi maxkoshevoi deleted the mk/65775-caching-memory branch March 5, 2022 07:01
@ghost ghost locked as resolved and limited conversation to collaborators Apr 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Extensions-Caching community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants