GetTypeFields should return ELEMENT_TYPE_BYREF.
#65880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Did not handle the ByReference<T> special case.
|
Tagging subscribers to this area: @tommcdon |
ghost
assigned 
AaronRobinsonMSFT
changed the title
GetTypeField should return ELEMENT_TYPE_BYREF.GetTypeFields should return ELEMENT_TYPE_BYREF.
13 tasks
tommcdon
approved these changes
Feb 25, 2022
noahfalk
reviewed
Feb 25, 2022
scenario and therefore is more confusing than helpful. Add a commment about the expectations of the returned values.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did not handle the
ByReference<T>special case.There is some white space changes as well and spacing that was very confusing. That is modified in this PR.
/cc @noahfalk @hoyosjs