Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DebuggerDisplay for serializer types #65971

Merged

Conversation

eiriktsarpalis
Copy link
Member

Fix #65960.

@ghost
Copy link

ghost commented Feb 28, 2022

Tagging subscribers to this area: @dotnet/area-system-text-json
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix #65960.

Author: eiriktsarpalis
Assignees: -
Labels:

area-System.Text.Json

Milestone: -

@eiriktsarpalis eiriktsarpalis requested a review from layomia March 3, 2022 12:29
@eiriktsarpalis eiriktsarpalis merged commit db73362 into dotnet:main Mar 4, 2022
@eiriktsarpalis eiriktsarpalis deleted the fix-serializer-debuggerdisplay branch March 4, 2022 16:14
@TonyValenti
Copy link

@eiriktsarpalis Can I make a suggestion?

In my own code, I create a constant that contains the debuggerdisplay,nq value and reference the constant everywhere. This keeps me from having to have the magic string everywhere.

Also, as a general rule, I've found it better to be a function rather than a property because sometimes it will wind up being serialized in weird places if it is a property.

Anyway, just a few thoughts. Do with them what you will.

@ghost ghost locked as resolved and limited conversation to collaborators Apr 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DebuggerDisplay] for JsonTypeInfo does not render
4 participants