Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cross-arch build compilation error about missing O_RDONLY #66094

Merged
merged 1 commit into from
Mar 2, 2022
Merged

Fix cross-arch build compilation error about missing O_RDONLY #66094

merged 1 commit into from
Mar 2, 2022

Conversation

stephentoub
Copy link
Member

@stephentoub stephentoub commented Mar 2, 2022 •
edited
Loading

I hit an error with the latest Visual Studio preview build.
cc: @janvorli

@ghost ghost assigned stephentoub Mar 2, 2022
@ghost
Copy link

ghost commented Mar 2, 2022

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

cc: @janvorli

Author: stephentoub
Assignees: stephentoub
Labels:

area-Infrastructure-coreclr
Milestone: -

adamsitnik
adamsitnik approved these changes Mar 2, 2022
View reviewed changes
Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm that it solves the problem:

image

@hoyosjs
Copy link
Member

hoyosjs commented Mar 2, 2022

Odd one hit, looks like #65914

Assert failure(PID 566 [0x00000236], Thread: 590 [0x024e]): waitResult == WAIT_TIMEOUT
    File: /__w/1/s/src/coreclr/vm/tieredcompilation.cpp Line: 507
    Image: /root/helix/work/correlation/dotnet

For the reflection issue created #66100 as it's hitting several builds.

janvorli
janvorli approved these changes Mar 2, 2022
View reviewed changes
Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@runfoapp runfoapp bot mentioned this pull request Mar 2, 2022
Closed
@stephentoub stephentoub merged commit d543bc4 into dotnet:main Mar 2, 2022
@stephentoub stephentoub deleted the fixcrossbuild branch March 2, 2022 21:29
@ghost ghost locked as resolved and limited conversation to collaborators Apr 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adamsitnik adamsitnik adamsitnik approved these changes

@janvorli janvorli janvorli approved these changes

@hoyosjs hoyosjs hoyosjs approved these changes

Assignees

@stephentoub stephentoub

Labels
area-Infrastructure-coreclr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stephentoub @hoyosjs @adamsitnik @janvorli