JIT: tolerate schema mismatches in partial compilation with pgo #66105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleanup properly if we fail to instrument because of a schema allocation failure. This fixes dotnet#65992. More work is needed to ensure schema allocation does not fail. This is tracked by dotnet#66101.
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT |
|
@kunalspathak PTAL (not adding tests yet, as partial comp + pgo is still a work in progress). |
|
Libraries failures are known issue, this change only impacts partial compilation. So will merge as is. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup properly if we fail to instrument because of a schema allocation
failure. This fixes #65992.
More work is needed to ensure schema allocation does not fail. This
is tracked by #66101.