-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't build IJW and COM host tests for mono #66400
Conversation
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
Side note/question: why are we building the native hosting tests and mock for mono? Do we actually run them with a mono based framework (as in |
Yeah, I was wondering that too (didn't look into it for the purposes of just getting this fix). I think the answer is that we don't need to and can just exclude everything in corehost/test - will check on that after this. |
There are community based configurations that only have mono as the runtime (s390x, for example). I think we still need this. |
The configurations actually run the installer/host tests? I know we need the host product itself, but for tests, I'm pretty sure a number of them aren't supported for mono (COM, startup hooks) and I don't think the tests do anything to exclude themselves from being run on mono. |
I took a closer look and I don't think we run the installer/host tests. |
Windows x64 Mono leg passed. Other extra-platforms failures are unrelated. Faliures in runtime pipeline are:
|
I missed that we had this condition for ijwhost and comhost, which is why the added ijw test fails to build.
runtime/src/native/corehost/CMakeLists.txt
Lines 35 to 40 in 4e75015
Fixes #66380