Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dotnet6 feeds #66447

Merged
merged 4 commits into from
Mar 17, 2022
Merged

Remove dotnet6 feeds #66447

merged 4 commits into from
Mar 17, 2022

Conversation

ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Mar 10, 2022

Fixes #57716

The current main branch's corresponding feeds are the dotnet7 ones and the dotnet6 ones shouldn't be used.
Please see my comments below for packages that were missing.

dotnet7 feeds are currently the target feeds for the main branch. The dotnet6 feeds shouldn't be used anymore.
@ghost
Copy link

ghost commented Mar 10, 2022

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

dotnet7 feeds are currently the target feeds for the main branch. The dotnet6 feeds shouldn't be used anymore.

Author: ViktorHofer
Assignees: ViktorHofer
Labels:

area-Infrastructure

Milestone: -

@ViktorHofer
Copy link
Member Author

ViktorHofer commented Mar 10, 2022

@dotnet/ncl the msquic transport package pushes into the dotnet7-transport feed but dotnet/runtime gets the version from the dotnet6-transport feed. I'm fixing the package version in dotnet/msquic#71 and am also updating the darc subscription so that it fetches the package from the dotnet7-transport feed instead.

@ViktorHofer
Copy link
Member Author

I manually pushed the latest dotnet/optimization packages to the dotnet7-transport feed as the dotnet/optimization builds are currently broken.

@ViktorHofer
Copy link
Member Author

/azp run dotnet-linker-tests

@ViktorHofer
Copy link
Member Author

/azp run runtime

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ViktorHofer
Copy link
Member Author

/azp run runtime-dev-innerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ViktorHofer
Copy link
Member Author

/azp run runtime-staging

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ViktorHofer ViktorHofer marked this pull request as ready for review March 15, 2022 15:30
@ViktorHofer ViktorHofer requested a review from a team March 15, 2022 15:30
Copy link
Member

@agocke agocke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ViktorHofer
Copy link
Member Author

ld : error : object file (/Users/runner/work/1/s/.packages/microsoft.netcore.app.host.osx-x64/6.0.3/runtimes/osx-x64/native/libnethost.a(nethost.cpp.o)) was built for newer macOS version (10.14) than being linked (10.13) [/Users/runner/work/1/s/src/libraries/System.Runtime.InteropServices/tests/TestAssets/NativeExports/NativeExports.csproj]
##[error]ld(0,0): error : (NETCORE_ENGINEERING_TELEMETRY=Build) object file (/Users/runner/work/1/s/.packages/microsoft.netcore.app.host.osx-x64/6.0.3/runtimes/osx-x64/native/libnethost.a(nethost.cpp.o)) was built for newer macOS version (10.14) than being linked (10.13)
ld : error : object file (/Users/runner/work/1/s/.packages/microsoft.netcore.app.host.osx-x64/6.0.3/runtimes/osx-x64/native/libnethost.a(nethost.cpp.o)) was built for newer macOS version (10.14) than being linked (10.13) [/Users/runner/work/1/s/src/libraries/System.Runtime.InteropServices/tests/TestAssets/NativeExports/NativeExports.csproj]
##[error]ld(0,0): error : (NETCORE_ENGINEERING_TELEMETRY=Build) object file (/Users/runner/work/1/s/.packages/microsoft.netcore.app.host.osx-x64/6.0.3/runtimes/osx-x64/native/libnethost.a(nethost.cpp.o)) was built for newer macOS version (10.14) than being linked (10.13)
ld : error : object file (/Users/runner/work/1/s/.packages/microsoft.netcore.app.host.osx-x64/6.0.3/runtimes/osx-x64/native/libnethost.a(utils.cpp.o)) was built for newer macOS version (10.14) than being linked (10.13) [/Users/runner/work/1/s/src/libraries/System.Runtime.InteropServices/tests/TestAssets/NativeExports/NativeExports.csproj]
##[error]ld(0,0): error : (NETCORE_ENGINEERING_TELEMETRY=Build) object file (/Users/runner/work/1/s/.packages/microsoft.netcore.app.host.osx-x64/6.0.3/runtimes/osx-x64/native/libnethost.a(utils.cpp.o)) was built for newer macOS version (10.14) than being linked (10.13)
ld : error : object file (/Users/runner/work/1/s/.packages/microsoft.netcore.app.host.osx-x64/6.0.3/runtimes/osx-x64/native/libnethost.a(utils.cpp.o)) was built for newer macOS version (10.14) than being linked (10.13) [/Users/runner/work/1/s/src/libraries/System.Runtime.InteropServices/tests/TestAssets/NativeExports/NativeExports.csproj]
##[error]ld(0,0): error : (NETCORE_ENGINEERING_TELEMETRY=Build) object file (/Users/runner/work/1/s/.packages/microsoft.netcore.app.host.osx-x64/6.0.3/runtimes/osx-x64/native/libnethost.a(utils.cpp.o)) was built for newer macOS version (10.14) than being linked (10.13)
ld : error : object file (/Users/runner/work/1/s/.packages/microsoft.netcore.app.host.osx-x64/6.0.3/runtimes/osx-x64/native/libnethost.a(fxr_resolver.cpp.o)) was built for newer macOS version (10.14) than being linked (10.13) [/Users/runner/work/1/s/src/libraries/System.Runtime.InteropServices/tests/TestAssets/NativeExports/NativeExports.csproj]
##[error]ld(0,0): error : (NETCORE_ENGINEERING_TELEMETRY=Build) object file (/Users/runner/work/1/s/.packages/microsoft.netcore.app.host.osx-x64/6.0.3/runtimes/osx-x64/native/libnethost.a(fxr_resolver.cpp.o)) was built for newer macOS version (10.14) than being linked (10.13)
ld : error : object file (/Users/runner/work/1/s/.packages/microsoft.netcore.app.host.osx-x64/6.0.3/runtimes/osx-x64/native/libnethost.a(fxr_resolver.cpp.o)) was built for newer macOS version (10.14) than being linked (10.13) [/Users/runner/work/1/s/src/libraries/System.Runtime.InteropServices/tests/TestAssets/NativeExports/NativeExports.csproj]
##[error]ld(0,0): error : (NETCORE_ENGINEERING_TELEMETRY=Build) object file (/Users/runner/work/1/s/.packages/microsoft.netcore.app.host.osx-x64/6.0.3/runtimes/osx-x64/native/libnethost.a(fxr_resolver.cpp.o)) was built for newer macOS version (10.14) than being linked (10.13)
ld : error : object file (/Users/runner/work/1/s/.packages/microsoft.netcore.app.host.osx-x64/6.0.3/runtimes/osx-x64/native/libnethost.a(trace.cpp.o)) was built for newer macOS version (10.14) than being linked (10.13) [/Users/runner/work/1/s/src/libraries/System.Runtime.InteropServices/tests/TestAssets/NativeExports/NativeExports.csproj]
##[error]ld(0,0): error : (NETCORE_ENGINEERING_TELEMETRY=Build) object file (/Users/runner/work/1/s/.packages/microsoft.netcore.app.host.osx-x64/6.0.3/runtimes/osx-x64/native/libnethost.a(trace.cpp.o)) was built for newer macOS version (10.14) than being linked (10.13)
ld : error : object file (/Users/runner/work/1/s/.packages/microsoft.netcore.app.host.osx-x64/6.0.3/runtimes/osx-x64/native/libnethost.a(trace.cpp.o)) was built for newer macOS version (10.14) than being linked (10.13) [/Users/runner/work/1/s/src/libraries/System.Runtime.InteropServices/tests/TestAssets/NativeExports/NativeExports.csproj]
##[error]ld(0,0): error : (NETCORE_ENGINEERING_TELEMETRY=Build) object file (/Users/runner/work/1/s/.packages/microsoft.netcore.app.host.osx-x64/6.0.3/runtimes/osx-x64/native/libnethost.a(trace.cpp.o)) was built for newer macOS version (10.14) than being linked (10.13)
ld : error : object file (/Users/runner/work/1/s/.packages/microsoft.netcore.app.host.osx-x64/6.0.3/runtimes/osx-x64/native/libnethost.a(pal.unix.cpp.o)) was built for newer macOS version (10.14) than being linked (10.13) [/Users/runner/work/1/s/src/libraries/System.Runtime.InteropServices/tests/TestAssets/NativeExports/NativeExports.csproj]
##[error]ld(0,0): error : (NETCORE_ENGINEERING_TELEMETRY=Build) object file (/Users/runner/work/1/s/.packages/microsoft.netcore.app.host.osx-x64/6.0.3/runtimes/osx-x64/native/libnethost.a(pal.unix.cpp.o)) was built for newer macOS version (10.14) than being linked (10.13)
ld : error : object file (/Users/runner/work/1/s/.packages/microsoft.netcore.app.host.osx-x64/6.0.3/runtimes/osx-x64/native/libnethost.a(pal.unix.cpp.o)) was built for newer macOS version (10.14) than being linked (10.13) [/Users/runner/work/1/s/src/libraries/System.Runtime.InteropServices/tests/TestAssets/NativeExports/NativeExports.csproj]

@jkoritzinsky as you added that path to the test project, would you know what needs to be updated to link against >= 10.14? Presumably this path

<TargetTriple Condition="'$(TargetArchitecture)' == 'arm64'">arm64-apple-macos11</TargetTriple>
<TargetTriple Condition="'$(TargetArchitecture)' == 'x64'">x86_64-apple-macos10.13</TargetTriple>
?

@jkoritzinsky
Copy link
Member

@ViktorHofer I believe you're correct. We should update line 76 to be x86_64-apple-macos10.14

@ViktorHofer ViktorHofer merged commit b5edcab into main Mar 17, 2022
@ViktorHofer ViktorHofer deleted the ViktorHofer-patch-1 branch March 17, 2022 07:42
radekdoulik pushed a commit to radekdoulik/runtime that referenced this pull request Mar 30, 2022
* Remove dotnet6 feeds

dotnet7 feeds are currently the target feeds for the main branch. The dotnet6 feeds shouldn't be used anymore.

* Update targetingpacks.targets

* Update prebuilt package versions

* Update NativeExports.csproj
@ghost ghost locked as resolved and limited conversation to collaborators Apr 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove dotnet6 feeds when dependencies publish into dotnet7 feeds.
3 participants