Fix too narrow loads while unspilling #66675
Conversation
Unspilling could produce too narrow loads for normalize-on-load variables when encountering a narrowly typed LCL_VAR node. This could result in subsequent uses of the same local using a truncated value. Fix dotnet#66624
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsUnspilling could produce too narrow loads for normalize-on-load Fix #66624
|
|
FWIW, it seems likely to me that we could always use 'wide' loads here, at least on non-ARM. We already do so for dependently promoted small fields (even unaligned) and when enregistering incoming stack args, so clearly these rely on upstream code to have inserted casts. However I preferred the smaller set of diffs here. |
|
/azp run Antigen, Fuzzlyn |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
No diffs cc @dotnet/jit-contrib PTAL @BruceForstall |
Unspilling could produce too narrow loads for normalize-on-load variables when encountering a narrowly typed LCL_VAR node. This could result in subsequent uses of the same local using a truncated value. Fix dotnet#66624
ghost
locked as resolved and limited conversation to collaborators
Unspilling could produce too narrow loads for normalize-on-load
variables when encountering a narrowly typed LCL_VAR node. This could
result in subsequent uses of the same local using a truncated value.
Fix #66624