Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mono] Fix static virtual calls to generic methods from gshared code #66739

Merged
merged 6 commits into from
Apr 1, 2022
Merged

[mono] Fix static virtual calls to generic methods from gshared code #66739

merged 6 commits into from
Apr 1, 2022

Commits on Mar 31, 2022

  1. [mono] Fix static virtual calls to generic methods from gshared code 

    When the resolved method from the vtable is generic, we need to inflate it.

For example, in the gshared method we are calling on `Interface.InterfaceMethod<int> ()` (the type argument can either be fixed or determined based on the gshared method's context), and this method is resolved to generic method `Class.InterfaceMethod<T> ()`. We then need to inflate the method and resolve `T` to `int`.
    @BrzVlad
    BrzVlad committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    aa4816f View commit details
    Browse the repository at this point in the history

  2. Enable tests

    @BrzVlad
    BrzVlad committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    59655be View commit details
    Browse the repository at this point in the history

  3. [mono][interp] Fix calls to static virtual methods via delegates

    @BrzVlad
    BrzVlad committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    5f8d4ae View commit details
    Browse the repository at this point in the history

  4. [mono][aot] Fix constrained + ldftn

    @BrzVlad
    BrzVlad committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    b59123f View commit details
    Browse the repository at this point in the history

  5. [mono][gsharing] Fix constrained + ldftn from gshared method 

    We can'd determine at compile time the static method if the constrained_class is a generic parameteri. We defer the computation of the method at runtime, in a similar fashion with calls.
    @BrzVlad
    BrzVlad committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    063ac31 View commit details
    Browse the repository at this point in the history

  6. Disable test suite on android 

    It hits an issue in the android test runner
    @BrzVlad
    BrzVlad committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    51df2dc View commit details
    Browse the repository at this point in the history