[release/6.0] Fix cancel in PipeReader.ReadAtLeastAsync #66870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
BrennanConroy
added
the
Servicing-consider
halter73
approved these changes
Mar 21, 2022
BrennanConroy
added
Servicing-approved
|
@BrennanConroy @halter73 I added the missing GeneratePackageOnBuild and bump version in the src csproj. |
|
This should be merged asap to make it into the May release |
This was referenced Apr 13, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #66752 to release/6.0
/cc @BrennanConroy
Customer Impact
Reported by customer in #66645.
This bug causes cancellation tokens to be ignored in some cases when using
PipeReader.ReadAtLeastAsyncwhich can create hangs.Testing
Added improved test coverage for cancellation tokens and verified the scenario provided is fixed.
Risk
Low. Very small fix that doesn't affect other code paths.