Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CoreCLR support for default interface implementation of static virtual methods #66887

Merged
merged 22 commits into from
Jun 1, 2022
Merged

CoreCLR support for default interface implementation of static virtual methods #66887

merged 22 commits into from
Jun 1, 2022

Commits on May 27, 2022

  1. Move the diamondshape test under StaticVirtualMethods

    @trylek
    trylek committed May 27, 2022
    Configuration menu
    Copy the full SHA
    5a16ec5 View commit details
    Browse the repository at this point in the history

  2. Modify the test to exercise static virtual methods

    @trylek
    trylek committed May 27, 2022
    Configuration menu
    Copy the full SHA
    07004ec View commit details
    Browse the repository at this point in the history

  3. Fixes to svm_diamondshape to make it build; initial runtime changes

    @trylek
    trylek committed May 27, 2022
    Configuration menu
    Copy the full SHA
    d50b834 View commit details
    Browse the repository at this point in the history

  4. One more fix to the new diamondshape test; more runtime fixes

    @trylek
    trylek committed May 27, 2022
    Configuration menu
    Copy the full SHA
    b89edd7 View commit details
    Browse the repository at this point in the history

  5. Partial change for default interface implementations of SVMs

    @trylek
    trylek committed May 27, 2022
    Configuration menu
    Copy the full SHA
    30eee66 View commit details
    Browse the repository at this point in the history

  6. Additional JIT changes to make default impl's of SVM resolve properly

    @trylek
    trylek committed May 27, 2022
    Configuration menu
    Copy the full SHA
    21610bc View commit details
    Browse the repository at this point in the history

  7. Fix temporary instrumentation

    @trylek
    trylek committed May 27, 2022
    Configuration menu
    Copy the full SHA
    7a2fbb9 View commit details
    Browse the repository at this point in the history

  8. Address initial JanK's PR feedback

    @trylek
    trylek committed May 27, 2022
    Configuration menu
    Copy the full SHA
    e402364 View commit details
    Browse the repository at this point in the history

  9. Add struct variants for the svm_diamondshape tests 

    This change extends the svm_diamondshape test to exercise value
types. As next step I'll work on testing the ldftn instruction.

Thanks

Tomas
    @trylek
    trylek committed May 27, 2022
    Configuration menu
    Copy the full SHA
    c1e1483 View commit details
    Browse the repository at this point in the history

  10. Add struct and ldftn testing per David's PR feedback

    @trylek
    trylek committed May 27, 2022
    Configuration menu
    Copy the full SHA
    32c3c9b View commit details
    Browse the repository at this point in the history

  11. Remove 'final' check; add reabstraction test cases

    @trylek
    trylek committed May 27, 2022
    Configuration menu
    Copy the full SHA
    3f0622e View commit details
    Browse the repository at this point in the history

  12. Fix a few syntax errors in the IL

    @trylek
    trylek committed May 27, 2022
    Configuration menu
    Copy the full SHA
    32c3fa2 View commit details
    Browse the repository at this point in the history

  13. Relax flag checking for reabstracted SVMs; runtime resolution test

    @trylek
    trylek committed May 27, 2022
    Configuration menu
    Copy the full SHA
    a36136b View commit details
    Browse the repository at this point in the history

  14. More changes based on David Wrighton's feedback

    @trylek
    trylek committed May 27, 2022
    Configuration menu
    Copy the full SHA
    2bad146 View commit details
    Browse the repository at this point in the history

  15. Additional changes for shared generic support

    @trylek
    trylek committed May 27, 2022
    Configuration menu
    Copy the full SHA
    01b38a2 View commit details
    Browse the repository at this point in the history

  16. Fix calling convention flag setting in getCallInfo

    @trylek
    trylek committed May 27, 2022
    Configuration menu
    Copy the full SHA
    7d0b7af View commit details
    Browse the repository at this point in the history

  17. Fix test C# source code according to the IL; fix a few IL typos

    @trylek
    trylek committed May 27, 2022
    Configuration menu
    Copy the full SHA
    8a873a4 View commit details
    Browse the repository at this point in the history

  18. Remove dummy 'else' block

    @trylek
    trylek committed May 27, 2022
    Configuration menu
    Copy the full SHA
    1d6d27f View commit details
    Browse the repository at this point in the history

Commits on May 30, 2022

  1. Fix failures in several pre-existing SVM tests 

    1. TryToResolveStaticVirtualMethodOnThisType doesn't need the
uniqueResolution flag - non-unique resolution on a single type
(i.o.w. multiple MethodImpl records resolving the same MethodDecl)
is always an error.

2. In getCallInfo, treat a SVM call as requiring runtime lookup
when the constrained type is a canonical subtype.

Thanks

Tomas
    @trylek
    trylek committed May 30, 2022
    Configuration menu
    Copy the full SHA
    23ce9aa View commit details
    Browse the repository at this point in the history

  2. Revert CORINFO_STATICVIRTUALCALL per Michal's PR feedback 

    As Michal pointed out, implementation of this call kind is quite
similar to CORINFO_CALL_CODE_POINTER; initially I had trouble
making it work but now the rest of the change is working fine
it turns out that CORINFO_CALL_CODE_POINTER works fine so I
removed the new kind I had originally introduced.

Thanks

Tomas
    @trylek
    trylek committed May 30, 2022
    Configuration menu
    Copy the full SHA
    21c38da View commit details
    Browse the repository at this point in the history

Commits on May 31, 2022

  1. Temporarily disable the SVM diamond shape test on mono with dotnet#70040 

    

Disable the test before the Mono support is provided.
    @trylek
    trylek committed May 31, 2022
    Configuration menu
    Copy the full SHA
    326dbec View commit details
    Browse the repository at this point in the history

  2. Remove the issues.targets entry to see if Mono works now

    @trylek
    trylek committed May 31, 2022
    Configuration menu
    Copy the full SHA
    9f4442e View commit details
    Browse the repository at this point in the history