-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JIT: block some struct promotion for OSR #67131
Conversation
This undoes part of dotnet#65903. OSR methods can't rely solely on their own analysis for struct promotion as they only see parts of methods.
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsThis undoes part of #65903. OSR methods can't rely solely on their own analysis
|
This has a handful of diffs in the aspnet collection. It will also likely have a negative perf impact on microbenchmarks, but I won't know the magnitude of that until after merging and letting the lab get a few days' worth of data. cc @dotnet/jit-contrib |
/azp run runtime-coreclr libraries-pgo |
Azure Pipelines successfully started running 1 pipeline(s). |
Unlikely that the libraries pgo will run cleanly, so I'll have to parse the results. Not sure why SPMI is failing, looks like infrastructure perhaps?
am going to retry |
Libraries failure is #66571 |
Libraries PGO tests look to be improved overall. |
SPMI seems to have passed on rerun but gotten a little confused. |
This undoes part of dotnet#65903. OSR methods can't rely solely on their own analysis for struct promotion as they only see parts of methods.
This undoes part of #65903. OSR methods can't rely solely on their own analysis
for struct promotion as they only see parts of methods.
Fixes #67078