Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JIT: block some struct promotion for OSR #67131

Merged
merged 1 commit into from
Mar 25, 2022

Conversation

AndyAyersMS
Copy link
Member

@AndyAyersMS AndyAyersMS commented Mar 25, 2022

This undoes part of #65903. OSR methods can't rely solely on their own analysis
for struct promotion as they only see parts of methods.

Fixes #67078

This undoes part of dotnet#65903. OSR methods can't rely solely on their own analysis
for struct promotion as they only see parts of methods.
@ghost ghost assigned AndyAyersMS Mar 25, 2022
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Mar 25, 2022
@ghost
Copy link

ghost commented Mar 25, 2022

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

This undoes part of #65903. OSR methods can't rely solely on their own analysis
for struct promotion as they only see parts of methods.

Author: AndyAyersMS
Assignees: AndyAyersMS
Labels:

area-CodeGen-coreclr

Milestone: -

@AndyAyersMS
Copy link
Member Author

This has a handful of diffs in the aspnet collection. It will also likely have a negative perf impact on microbenchmarks, but I won't know the magnitude of that until after merging and letting the lab get a few days' worth of data.

cc @dotnet/jit-contrib

@AndyAyersMS
Copy link
Member Author

/azp run runtime-coreclr libraries-pgo

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@AndyAyersMS
Copy link
Member Author

Unlikely that the libraries pgo will run cleanly, so I'll have to parse the results.

Not sure why SPMI is failing, looks like infrastructure perhaps?

Invoking: git log --pretty=format:%H aea7c73b6be57845df53880cf95b3f7fa58e477c -20 -- src/coreclr/jit/*

try 1: 3fe2959f3e0c7255a90098946e57e6e7294476b1

Didn't find any collections using https://clrjit2.blob.core.windows.net/jitrollingbuild?restype=container&comp=list&prefix=builds/3fe2959f3e0c7255a90098946e57e6e7294476b1/windows/x64/Checked

  Error: [WinError 10054] An existing connection was forcibly closed by the remote host


Traceback (most recent call last):

  File "D:\a\_work\1\s\src\coreclr\scripts\jitrollingbuild.py", line 815, in <module>

    sys.exit(main(args))

  File "D:\a\_work\1\s\src\coreclr\scripts\jitrollingbuild.py", line 797, in main

    download_command(coreclr_args)

  File "D:\a\_work\1\s\src\coreclr\scripts\jitrollingbuild.py", line 639, in download_command

    if len(urls) == 0:

TypeError: object of type 'NoneType' has no len()


D:\a\_work\1\s\src\coreclr\scripts\jitrollingbuild.py failed with 1

am going to retry

@AndyAyersMS
Copy link
Member Author

Libraries failure is #66571

@AndyAyersMS
Copy link
Member Author

Libraries PGO tests look to be improved overall.

@AndyAyersMS
Copy link
Member Author

SPMI seems to have passed on rerun but gotten a little confused.

@AndyAyersMS AndyAyersMS merged commit 6627183 into dotnet:main Mar 25, 2022
radekdoulik pushed a commit to radekdoulik/runtime that referenced this pull request Mar 30, 2022
This undoes part of dotnet#65903. OSR methods can't rely solely on their own analysis
for struct promotion as they only see parts of methods.
@ghost ghost locked as resolved and limited conversation to collaborators Apr 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OSR stress failure in System.Diagnostics.DiagnosticsSource.Tests
2 participants