Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nullable annotations for System.Security.Cryptography.Xml #67198
Nullable annotations for System.Security.Cryptography.Xml #67198
Changes from all commits
1707477
431c22e
7146969
e3d32f5
78c8114
cfe5c9d
c8a3983
a5a1085
9be11d8
7d4b1ae
f9e3066
79d8688
71db6e3
408d355
d32935d
5b35583
e4d3350
1f75d3c
753b05f
fd784fb
3419961
d3180bb
29f13a6
a3d906a
fdb26d4
fe764fa
86e1784
d76993c
f4acf19
295698d
c394bc0
917af63
3ee8598
c332f84
e29fc43
67bd994
ccb6a3f
e13afbf
ee8a0aa
987940a
11dfa6d
9e65051
7f0dcd0
836f21c
943a5d6
f3a4984
11fac03
321e958
9418cf3
3324d39
e4af751
2642850
98a6572
9c033c7
0ce398f
fe63a28
03f8452
2866e92
5a24eae
8e00c00
c3bbe9e
7b1ca68
f47ad41
e952d69
32bb40d
9fda330
e768859
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it actually possible for this to return null? we seem to be throwing when user tries to add null
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't look like it, but it must match the index operator for
IList
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't expect this to be fixed, just unresolving as FYI:
for return values you can make it non-nullable even if interface returns nullable (for setter it has to match but you can make it non-nullable with
[AllowNull]
)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't really matter for explicit interface implementations; no one ever sees these annotations (other than someone looking for them via reflection).