[Group 4] Enable nullable annotations for Microsoft.Extensions.Logging.EventLog
#67200
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #43605
Okay, so here's the thing.
System.Diagnostics.EventLog
is not annotated yet, and a lot of effort is needed to do it.Here it's used only in
WindowsEventLog
which isinternal
, and nothing calls it withnull
, so it's should be safe to leave everything in is as non-nullable.I may get around to annotate
System.Diagnostics.EventLog
in the future.