Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Group 4] Enable nullable annotations for Microsoft.Extensions.Logging.EventLog #67200

Merged
merged 1 commit into from
Apr 1, 2022

Conversation

maxkoshevoi
Copy link
Contributor

Related to #43605

Okay, so here's the thing. System.Diagnostics.EventLog is not annotated yet, and a lot of effort is needed to do it.
Here it's used only in WindowsEventLog which is internal, and nothing calls it with null, so it's should be safe to leave everything in is as non-nullable.

I may get around to annotate System.Diagnostics.EventLog in the future.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Mar 27, 2022
@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Mar 27, 2022

Tagging subscribers to this area: @dotnet/area-extensions-logging
See info in area-owners.md if you want to be subscribed.

Issue Details

Related to #43605

Okay, so here's the thing. System.Diagnostics.EventLog is not annotated yet, and a lot of effort is needed to do it.
Here it's used only in WindowsEventLog which is internal, and nothing calls it with null, so it's should be safe to leave everything in is as non-nullable.

I may get around to annotate System.Diagnostics.EventLog in the future.

Author: maxkoshevoi
Assignees: -
Labels:

new-api-needs-documentation, area-Extensions-Logging, community-contribution

Milestone: -

@tarekgh
Copy link
Member

tarekgh commented Apr 1, 2022

@maryamariyan the changes here look good to me. Are you interested to take a quick look?

@tarekgh tarekgh merged commit ececd64 into dotnet:main Apr 1, 2022
@maxkoshevoi maxkoshevoi deleted the mk/43605-logging-eventlog branch April 1, 2022 18:53
@ghost ghost locked as resolved and limited conversation to collaborators May 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Extensions-Logging community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants