Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed dump path in HTTP stress test #67230

Merged
merged 1 commit into from
Mar 29, 2022
Merged

Fixed dump path in HTTP stress test #67230

merged 1 commit into from
Mar 29, 2022

Conversation

ManickaP
Copy link
Member

@ghost ghost assigned ManickaP Mar 28, 2022
@ghost
Copy link

ghost commented Mar 28, 2022

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

cc @antonfirsov @rzikm

Author: ManickaP
Assignees: ManickaP
Labels:

area-System.Net.Http
Milestone: -

@ManickaP ManickaP force-pushed the mapichov/fix_stress branch 3 times, most recently from f044a5f to ff7792e Compare March 28, 2022 18:58
@dotnet dotnet deleted a comment from azure-pipelines bot Mar 28, 2022
@dotnet dotnet deleted a comment from azure-pipelines bot Mar 28, 2022
@dotnet dotnet deleted a comment from azure-pipelines bot Mar 28, 2022
@ManickaP
Copy link
Member Author

/azp run runtime-libraries stress-http

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ManickaP
Copy link
Member Author

This run: https://dev.azure.com/dnceng/public/_build/results?buildId=1686263&view=results shows published artifacts when the stress crashes. I had Environment.FailFast temporarily in to test it, it's now removed and the latest run is check if it actually runs.

@ManickaP ManickaP mentioned this pull request Mar 28, 2022
Merged
@ManickaP
Copy link
Member Author

The latest stress pipeline run "passes": https://dev.azure.com/dnceng/public/_build/results?buildId=1686438&view=results
E.g. The stress runs all legs, just H/3 have few errors as it does most of the time, it corresponds to our baseline.

Could someone please review this PR then?

@ManickaP ManickaP requested a review from a team March 29, 2022 08:29
rzikm
rzikm approved these changes Mar 29, 2022
View reviewed changes
Copy link
Member

@rzikm rzikm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CarnaViire
CarnaViire approved these changes Mar 29, 2022
View reviewed changes
Copy link
Member

@CarnaViire CarnaViire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ManickaP ManickaP merged commit e95ba4b into main Mar 29, 2022
@ManickaP ManickaP deleted the mapichov/fix_stress branch March 29, 2022 14:51
@karelz karelz added this to the 7.0.0 milestone Apr 8, 2022
@ghost ghost locked as resolved and limited conversation to collaborators May 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@CarnaViire CarnaViire CarnaViire approved these changes

@rzikm rzikm rzikm approved these changes

Assignees

@ManickaP ManickaP

Labels
area-System.Net.Http
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ManickaP @CarnaViire @rzikm @karelz