Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Referencing Unsafe Package in System.Diagnostics.DiagnosticSource #67322

Merged
merged 1 commit into from
Mar 30, 2022

Conversation

tarekgh
Copy link
Member

@tarekgh tarekgh commented Mar 30, 2022

Fixes #67196

Apply @ViktorHofer suggestion #67196 (comment) to always allow referencing the latest Unsafe package in System.Diagnostics.DiagnosticSource.

Fix some doc references in Metrics APIs.

@ghost
Copy link

ghost commented Mar 30, 2022

Tagging subscribers to this area: @tarekgh, @tommcdon, @pjanotti
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #67196

Apply @ViktorHofer suggestion #67196 (comment) to always allow referencing the latest Unsafe package in System.Diagnostics.DiagnosticSource.

Fix some doc references in Metrics APIs.

Author: tarekgh
Assignees: -
Labels:

area-System.Diagnostics.Tracing

Milestone: -

@ghost
Copy link

ghost commented Mar 30, 2022

Tagging subscribers to this area: @dotnet/area-system-diagnostics-activity
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #67196

Apply @ViktorHofer suggestion #67196 (comment) to always allow referencing the latest Unsafe package in System.Diagnostics.DiagnosticSource.

Fix some doc references in Metrics APIs.

Author: tarekgh
Assignees: tarekgh
Labels:

area-System.Diagnostics.Activity

Milestone: -

@tarekgh tarekgh added this to the 7.0.0 milestone Mar 30, 2022
@tarekgh tarekgh merged commit 6ba20ab into dotnet:main Mar 30, 2022
@tarekgh tarekgh deleted the FixReferencingUnsafePackage branch March 30, 2022 19:46
@ghost ghost locked as resolved and limited conversation to collaborators Apr 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Seemed the System.Runtime.CompilerServices.Unsafe is not necessary for .NET 6 +
4 participants