Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable all StructABI tests in pri-0 #67362

Merged
merged 1 commit into from
Mar 31, 2022
Merged

Enable all StructABI tests in pri-0 #67362

merged 1 commit into from
Mar 31, 2022

Conversation

BruceForstall
Copy link
Member

Struct-related ABI regression tests are important. This would have (presumably) caught #67355 in normal CI without triggering outerloop

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Mar 30, 2022
@ghost ghost assigned BruceForstall Mar 30, 2022
@ghost
Copy link

ghost commented Mar 30, 2022

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

Struct-related ABI regression tests are important. This would have (presumably) caught #67355 in normal CI without triggering outerloop

Author: BruceForstall
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: -

@BruceForstall
Copy link
Member Author

@dotnet/jit-contrib PTAL

@BruceForstall
Copy link
Member Author

cc @SingleAccretion

SingleAccretion
SingleAccretion approved these changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@SingleAccretion SingleAccretion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@BruceForstall
Copy link
Member Author

The CI failures are all expected, fixed by #67360

@BruceForstall BruceForstall merged commit d051a5d into dotnet:main Mar 31, 2022
@BruceForstall BruceForstall deleted the EnableAllStructAbiPri0 branch March 31, 2022 00:27
@ghost ghost locked as resolved and limited conversation to collaborators Apr 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SingleAccretion SingleAccretion SingleAccretion approved these changes

@AndyAyersMS AndyAyersMS AndyAyersMS approved these changes

Assignees

@BruceForstall BruceForstall

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BruceForstall @AndyAyersMS @SingleAccretion