Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JIT: Disable cast profiling by default #67460

Merged
merged 1 commit into from
Apr 2, 2022
Merged

Conversation

EgorBo
Copy link
Member

@EgorBo EgorBo commented Apr 1, 2022

Accidently left these enabled in #65922

DOTNET_JitProfileCasts is only supposed to be used for mibc, it's too heavy for DynamicPGO
DOTNET_JitConsumeProfileForCasts will be enabled by default once mibc is updated

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 1, 2022
@ghost ghost assigned EgorBo Apr 1, 2022
@ghost
Copy link

ghost commented Apr 1, 2022

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

Accidently left these enabled in #65922

DOTNET_JitProfileCasts is only supposed to be used for mibc, it's to heavy for DynamicPGO
JitConsumeProfileForCasts will be enabled by default once mibc is updated

Author: EgorBo
Assignees: -
Labels:

area-CodeGen-coreclr

Milestone: -

@EgorBo EgorBo requested a review from jakobbotsch April 1, 2022 21:40
@EgorBo EgorBo merged commit 0c1fbe0 into dotnet:main Apr 2, 2022
@ghost ghost locked as resolved and limited conversation to collaborators May 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants