-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm] EmccCompile: Add support for compiling sequentially #67483
Conversation
This adds support for two cases: 1. Compiling an assembly in parallel fails due to getting oomkill'ed. In this case, it will get compiled again but not in parallel with anything else. 2. User specified assemblies that should always be compiled sequentially. This would be useful for cases where some assemblies fail to compile because `emcc` runs out of memory. New: ``` - $(WasmRetrySequentiallyIfNeeded) - Retry assembly compilation to .o files sequentially, if needed. One such case could be if the compiler got killed due to OOM. Defaults to true. - @(WasmAssemblyToAOTSequentially) - Filenames of assemblies to always compile (to .o) sequentially ```
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsThis adds support for two cases:
This would be useful for cases where some assemblies fail to compile New:
|
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
Not sure that a build system should retry failing commands. Would a setting limiting the amount of parallelism, like make's -j argument work ? |
Using only I have removed the |
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
@ankit do you still think this is useful? |
This pull request has been automatically marked |
Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it. |
Add support for user specified assemblies that should always be compiled
sequentially. This would be useful for cases where some assemblies fail to compile
because
emcc
runs out of memory when compiled in parallel with other assemblies.New: