Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type activator should be order agnostic #67493

Closed
wants to merge 30 commits into from
Closed

Type activator should be order agnostic #67493

wants to merge 30 commits into from

Commits on Apr 2, 2022

  1. Type activator depends on constructors definition order if preferred … 

    …constructor is marked
    @mapogolions
    mapogolions committed Apr 2, 2022
    Configuration menu
    Copy the full SHA
    6d88e34 View commit details
    Browse the repository at this point in the history

  2. constructor marked as preferred should be considered the first option

    @mapogolions
    mapogolions committed Apr 2, 2022
    Configuration menu
    Copy the full SHA
    4381820 View commit details
    Browse the repository at this point in the history

  3. prevent parameter matching in case it is known that it will fail befo… 

    …re it even starts
    @mapogolions
    mapogolions committed Apr 2, 2022
    Configuration menu
    Copy the full SHA
    a859ea8 View commit details
    Browse the repository at this point in the history

  4. break loop if a perfect constructor is found

    @mapogolions
    mapogolions committed Apr 2, 2022
    Configuration menu
    Copy the full SHA
    6f74f65 View commit details
    Browse the repository at this point in the history

  5. add empty line

    @mapogolions
    mapogolions committed Apr 2, 2022
    Configuration menu
    Copy the full SHA
    ed5655f View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2022

  1. replace the wasteful array construction operation

    @mapogolions
    mapogolions committed Apr 3, 2022
    Configuration menu
    Copy the full SHA
    2491f50 View commit details
    Browse the repository at this point in the history

  2. rename local variable

    @mapogolions
    mapogolions committed Apr 3, 2022
    Configuration menu
    Copy the full SHA
    5dab06b View commit details
    Browse the repository at this point in the history

  3. fix indent, rename unit test

    @mapogolions
    mapogolions committed Apr 3, 2022
    Configuration menu
    Copy the full SHA
    9cdbf31 View commit details
    Browse the repository at this point in the history

  4. remove nullable operator

    @mapogolions
    mapogolions committed Apr 3, 2022
    Configuration menu
    Copy the full SHA
    d9c5458 View commit details
    Browse the repository at this point in the history

  5. reproduce issue dotnet#46132

    @mapogolions
    mapogolions committed Apr 3, 2022
    Configuration menu
    Copy the full SHA
    d646ee1 View commit details
    Browse the repository at this point in the history

  6. fix issue 46132

    @mapogolions
    mapogolions committed Apr 3, 2022
    Configuration menu
    Copy the full SHA
    92f188b View commit details
    Browse the repository at this point in the history

  7. remove prioritized constructor matcher

    @mapogolions
    mapogolions committed Apr 3, 2022
    Configuration menu
    Copy the full SHA
    1012cf0 View commit details
    Browse the repository at this point in the history

  8. specify issue

    @mapogolions
    mapogolions committed Apr 3, 2022
    Configuration menu
    Copy the full SHA
    fb7264a View commit details
    Browse the repository at this point in the history

  9. refactoring

    @mapogolions
    mapogolions committed Apr 3, 2022
    Configuration menu
    Copy the full SHA
    9beb319 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2022

  1. fix sorting

    @mapogolions
    mapogolions committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    d93c558 View commit details
    Browse the repository at this point in the history

  2. add additional checks

    @mapogolions
    mapogolions committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    a935ddc View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2022

  1. chooses default constructor no matter order

    @mapogolions
    mapogolions committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    6d8fdc2 View commit details
    Browse the repository at this point in the history

  2. type activator uses longest available constructor when multiple const… 

    …ructors are available
    @mapogolions
    mapogolions committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    fe1c38e View commit details
    Browse the repository at this point in the history

  3. refactoring

    @mapogolions
    mapogolions committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    7e4a363 View commit details
    Browse the repository at this point in the history

  4. update method signature

    @mapogolions
    mapogolions committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    7aabe2c View commit details
    Browse the repository at this point in the history

  5. should use the longest available constructor among constructors with … 

    …the same priority
    @mapogolions
    mapogolions committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    9927510 View commit details
    Browse the repository at this point in the history

  6. Update src/libraries/Microsoft.Extensions.DependencyInjection/tests/D… 

    …I.Tests/ActivatorUtilitiesTests.cs

Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
    @mapogolions @eerhardt
    mapogolions and eerhardt committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    68ff999 View commit details
    Browse the repository at this point in the history

  7. Update src/libraries/Microsoft.Extensions.DependencyInjection/tests/D… 

    …I.Tests/ActivatorUtilitiesTests.cs

Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
    @mapogolions @eerhardt
    mapogolions and eerhardt committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    175c637 View commit details
    Browse the repository at this point in the history

  8. Update src/libraries/Microsoft.Extensions.DependencyInjection.Abstrac… 

    …tions/src/ActivatorUtilities.cs

Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
    @mapogolions @eerhardt
    mapogolions and eerhardt committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    e03f785 View commit details
    Browse the repository at this point in the history

  9. remove dead code

    @mapogolions
    mapogolions committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    35f0d21 View commit details
    Browse the repository at this point in the history

  10. fix typo

    @mapogolions
    mapogolions committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    d9052f1 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'main' into type-activator-should-be-order-agnostic

    @mapogolions
    mapogolions committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    9ca1980 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2022

  1. rename test cases, remove useless code

    @mapogolions
    mapogolions committed Apr 30, 2022
    Configuration menu
    Copy the full SHA
    219e21b View commit details
    Browse the repository at this point in the history

  2. remove assert

    @mapogolions
    mapogolions committed Apr 30, 2022
    Configuration menu
    Copy the full SHA
    686d660 View commit details
    Browse the repository at this point in the history

  3. add extra test for the longest available constructor rule

    @mapogolions
    mapogolions committed Apr 30, 2022
    Configuration menu
    Copy the full SHA
    3facdfe View commit details
    Browse the repository at this point in the history