Use "..."u8 in dotnet/runtime

[stephentoub]

No description provided.

[ghost]

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

Issue Details

---

null

Author:	stephentoub
Assignees:	stephentoub
Labels:	area-Meta
Milestone:	-

[teo-tsirpanis]

I am working on https://github.com/dotnet/runtime/blob/main/src/libraries/System.Reflection.MetadataLoadContext/src/System/Reflection/TypeLoading/General/Utf8Constants.cs which I see you missed.

[stephentoub]

Thank you for pointing out the omission. I can add it here, and also search for anything else like this I may have missed. I didn't pay attention to byte[]s being filled with seemingly arbitrary numbers, as opposed to (byte)'char'.

[marek-safar]

I'm surprised there is nothing in CoreLib.

[stephentoub]

I'm surprised there is nothing in CoreLib

Do you know of any there? This was search/replace based on specific patterns. I'm sure there are others with more complicated patterns.

[teo-tsirpanis]

[stephentoub]

Most of those aren't strings, e. g. the first ones are number of days in each month. We shouldn't use u8 to encode arbitrary data.

[teo-tsirpanis]

I didn't say to make them u8, I pointed out that there isn't anything missed in Corelib.

[stephentoub]

I didn't say to make them u8, I pointed out that there isn't anything missed in Corelib.

Ah, thanks :-)

[marek-safar]

Perhaps I misunderstood the feature as I was thinking that it could help with strings like

runtime/src/libraries/System.Private.CoreLib/src/System/Globalization/DateTimeFormat.cs

Line 146 in 322ea09

internal static string[] fixedNumberFormats = new string[] {

or

runtime/src/libraries/Common/src/System/Globalization/FormatProvider.Number.cs

Line 634 in 57bfe47

private static readonly string[] s_negCurrencyFormats =

[stephentoub]

Perhaps I misunderstood the feature as I was thinking that it could help with strings like

The feature is basically that you write "text"u8 and at C# compile-time the compiler produces the logical equivalent of new byte[] { (byte)'t', (byte)'e', (byte)'x', (byte)'t' }.

[stephentoub]

I'm going to close this for now and will redo it once we have a compiler that adapts to recent design decisions around u8.