JIT: fix interaction of OSR and shadowed parameters #67884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a Tier0 method has shadowed parameters, the patchpoint info it creates must refer to the stack slots for the shadow copies. Otherwise any updates made to the params by the Tier0 code will not be seen by the OSR method. Fixes dotnet#67410.
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsIf a Tier0 method has shadowed parameters, the patchpoint info it creates Fixes #67410.
|
|
@EgorBo PTAL |
|
All the failures are in |
EgorBo
approved these changes
Apr 12, 2022
72 tasks
AndyAyersMS
added a commit
to AndyAyersMS/runtime
that referenced
this pull request
Apr 14, 2022
As a result of dotnet#67884, OSR compilations were looking at data in the `gsShadowVarInfo` array in cases where it was not initialized. Fix is to defer allocating the `gsShadowVarInfo` array until it's certain it will be initialized. Fixes dotnet#68003.
AndyAyersMS
added a commit
that referenced
this pull request
Apr 15, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a Tier0 method has shadowed parameters, the patchpoint info it creates
must refer to the stack slots for the shadow copies. Otherwise any updates
made to the params by the Tier0 code will not be seen by the OSR method.
Fixes #67410.