Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-enable TLS 13 tests on Windows #68009

Merged
merged 1 commit into from
Apr 15, 2022
Merged

re-enable TLS 13 tests on Windows #68009

merged 1 commit into from
Apr 15, 2022

Conversation

wfurt
Copy link
Member

@wfurt wfurt commented Apr 14, 2022

While the underlying issue lives in Schannel and it is being fixed in Windows the root analyses points to certificates with CAPI provider. That works fine for previous TLS versions but it fails for TLS 1.3 as that is somehow different.

This change brings new pfx files from dotnet/runtime-assets#234
With updated data (essentially still same certificate) everything seems to be stable.

This is only fix for the

---- System.ComponentModel.Win32Exception : The Local Security Authority cannot be contacted

other (recent server 2022) failures are unrelated to this.

fixes #58927

@wfurt wfurt added the test-enhancement Improvements of test source code label Apr 14, 2022
@wfurt wfurt requested a review from a team April 14, 2022 05:34
@wfurt wfurt self-assigned this Apr 14, 2022
@ghost
Copy link

ghost commented Apr 14, 2022

Tagging subscribers to this area: @dotnet/ncl, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

While the underlying issue lives in Schannel and it is being fixed in Windows the root analyses points to certificates with CAPI provider. That works fine for previous TLS versions but it fails for TLS 1.3 as that is somehow different.

This change brings new pfx files from dotnet/runtime-assets#234
With updated data (essentially still same certificate) everything seems to be stable.

This is only fix for the

---- System.ComponentModel.Win32Exception : The Local Security Authority cannot be contacted

other (recent server 2022) failures are unrelated to this.

fixes #58927

Author: wfurt
Assignees: wfurt
Labels:

area-System.Net.Security, test-enhancement

Milestone: -

Copy link
Member

@rzikm rzikm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wfurt
Copy link
Member Author

wfurt commented Apr 15, 2022

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wfurt
Copy link
Member Author

wfurt commented Apr 15, 2022

test failures are #67682, #67685 and perhaps others. #68083 should fix the Server 2022 failures. I did not see any The Local Security Authority cannot be contacted. I'll keep watching the runs.

@wfurt wfurt merged commit cd3328d into dotnet:main Apr 15, 2022
@wfurt wfurt deleted the win11cert branch April 15, 2022 17:49
@ghost ghost locked as resolved and limited conversation to collaborators May 15, 2022
@karelz karelz added this to the 7.0.0 milestone Jul 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Net.Security test-enhancement Improvements of test source code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TLS1.3 networking tests are flaky on Windows 11
3 participants