Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not discard byref zeros in native int + byref additions #68086

Merged
merged 2 commits into from
May 12, 2022

Conversation

SingleAccretion
Copy link
Contributor

@SingleAccretion SingleAccretion commented Apr 15, 2022

This should:

a) Ensure we're not "losing" the fact ADD produces a newly-born GC value (a mostly theoretical issue).
b) Reinstate the assert from #67600.

Diffs.

Fixes #67600.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Apr 15, 2022
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 15, 2022
@ghost
Copy link

ghost commented Apr 15, 2022

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

This should:

a) Ensure we're not "losing" the fact a tree produced a newly-born GC value (a mostly theoretical issue).
b) Reinstate the assert from #67600.

We're not expecting significant diffs.

Author: SingleAccretion
Assignees: -
Labels:

area-CodeGen-coreclr, community-contribution

Milestone: -

@SingleAccretion
Copy link
Contributor Author

@dotnet/jit-contrib I would like to request a run of runtime-coreclr libraries-jitstress for this change.

@jakobbotsch
Copy link
Member

/azp run runtime-coreclr libraries-jitstress

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@SingleAccretion
Copy link
Contributor Author

SingleAccretion commented Apr 16, 2022

Libraries stress "passed", so at least in the first approximation this fix should be sufficient.

Failures:

  1. Linux_musl arm64 Debug: looks related to Segmentation fault in LibraryImportGenerator.Unit.Tests #67031.
  2. OSX x64 checked: no existing issue, but does not look related (perhaps could be re-run).
  3. Libraries stress, Linux arm Release: Assert failure: !CREATE_CHECK_STRING(pMT && pMT->Validate()) #67046.
  4. Libraries stress, windows x86 Release: JSON flaky tests #67761.
  5. Libraries stress, windows arm64 Release:

@SingleAccretion SingleAccretion marked this pull request as ready for review April 16, 2022 14:25
@SingleAccretion
Copy link
Contributor Author

@dotnet/jit-contrib

@BruceForstall BruceForstall self-assigned this Apr 25, 2022
@SingleAccretion SingleAccretion force-pushed the Fixing-Discarding-Null-Byrefs branch from 607205c to 7b0fb75 Compare May 2, 2022 12:45
@SingleAccretion SingleAccretion force-pushed the Fixing-Discarding-Null-Byrefs branch from 7b0fb75 to 7586ba5 Compare May 8, 2022 14:23
@SingleAccretion SingleAccretion force-pushed the Fixing-Discarding-Null-Byrefs branch from 7586ba5 to 97f32cf Compare May 10, 2022 15:35
Copy link
Contributor

@TIHan TIHan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@TIHan TIHan merged commit 70b5d83 into dotnet:main May 12, 2022
@SingleAccretion SingleAccretion deleted the Fixing-Discarding-Null-Byrefs branch May 12, 2022 15:10
@ghost ghost locked as resolved and limited conversation to collaborators Jun 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failure: Assertion failed 'addr->TypeIs(TYP_BYREF) || addr->IsIntegralConst(0)'
5 participants