-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not discard byref zeros in native int + byref
additions
#68086
Do not discard byref zeros in native int + byref
additions
#68086
Conversation
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsThis should: a) Ensure we're not "losing" the fact a tree produced a newly-born GC value (a mostly theoretical issue). We're not expecting significant diffs.
|
@dotnet/jit-contrib I would like to request a run of |
/azp run runtime-coreclr libraries-jitstress |
Azure Pipelines successfully started running 1 pipeline(s). |
Libraries stress "passed", so at least in the first approximation this fix should be sufficient. Failures:
|
@dotnet/jit-contrib |
607205c
to
7b0fb75
Compare
7b0fb75
to
7586ba5
Compare
7586ba5
to
97f32cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
This should:
a) Ensure we're not "losing" the fact
ADD
produces a newly-born GC value (a mostly theoretical issue).b) Reinstate the assert from #67600.
Diffs.
Fixes #67600.