Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cmake RPATH CMP0068 warnings #68095

Merged
merged 1 commit into from
Apr 19, 2022
Merged

Fix cmake RPATH CMP0068 warnings #68095

merged 1 commit into from
Apr 19, 2022

Conversation

mikem8361
Copy link
Member

Fixes issue #41084.

The DBI module's install name, dependences and RPATHs are still the same as before and the warnings are gone.

$ otool -D libmscordbi.dylib
libmscordbi.dylib:
@rpath/libmscordbi.dylib

$ otool -L libmscordbi.dylib
libmscordbi.dylib:
        @rpath/libmscordbi.dylib (compatibility version 0.0.0, current version 0.0.0)
        @rpath/libmscordaccore.dylib (compatibility version 0.0.0, current version 0.0.0)
        /usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 1200.3.0)
        /usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1311.0.0)

$ otool -l libmscordbi.dylib | grep -i LC_RPATH -A2
          cmd LC_RPATH
      cmdsize 32
         path @loader_path (offset 12)

@mikem8361 mikem8361 requested a review from janvorli April 15, 2022 23:16
@mikem8361 mikem8361 self-assigned this Apr 15, 2022
@ghost
Copy link

ghost commented Apr 15, 2022

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes issue #41084.

The DBI module's install name, dependences and RPATHs are still the same as before and the warnings are gone.

$ otool -D libmscordbi.dylib
libmscordbi.dylib:
@rpath/libmscordbi.dylib

$ otool -L libmscordbi.dylib
libmscordbi.dylib:
        @rpath/libmscordbi.dylib (compatibility version 0.0.0, current version 0.0.0)
        @rpath/libmscordaccore.dylib (compatibility version 0.0.0, current version 0.0.0)
        /usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 1200.3.0)
        /usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1311.0.0)

$ otool -l libmscordbi.dylib | grep -i LC_RPATH -A2
          cmd LC_RPATH
      cmdsize 32
         path @loader_path (offset 12)
Author: mikem8361
Assignees: mikem8361
Labels:

area-Infrastructure-coreclr
Milestone: -

janvorli
janvorli approved these changes Apr 19, 2022
View reviewed changes
Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo the nit. Thank you!

src/coreclr/dlls/mscordbi/CMakeLists.txt
set(CMAKE_INSTALL_RPATH "@loader_path")
else()
set(CMAKE_BUILD_WITH_INSTALL_RPATH TRUE)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nit - it seems this can be left at the original location (and removed from the if branch again)

@mikem8361 mikem8361 merged commit b364067 into dotnet:main Apr 19, 2022
@mikem8361 mikem8361 deleted the cmp0068 branch April 19, 2022 14:11
directhex pushed a commit to directhex/runtime that referenced this pull request Apr 21, 2022
@mikem8361 @directhex
Fix issue dotnet#41084 - fix cmake CMP0068 warnings (dotnet#68095)
6bb98cc
@mikem8361 mikem8361 mentioned this pull request Apr 25, 2022
Closed
@ghost ghost locked as resolved and limited conversation to collaborators May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@janvorli janvorli janvorli approved these changes

Assignees

@mikem8361 mikem8361

Labels
area-Infrastructure-coreclr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikem8361 @janvorli