Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of !! from dotnet/runtime #68178

Merged
merged 5 commits into from
Apr 21, 2022

Commits on Apr 21, 2022

  1. Remove usage of !! from dotnet/runtime

    - Use ArgumentNullException.ThrowIfNull instead where possible.  It's only usable for projects that only target .NET 6+, and it can't be used in places like this(...) or base(...).
    - In other cases, if the project already has a ThrowHelper, augment it for null as needed and use that.
    - For most of the extensions projects, add a ThrowHelper.ThrowIfNull that replicates ArgumentNullException.ThrowIfNull.
    - For everything else, just use "throw new".
    stephentoub committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    5a02461 View commit details
    Browse the repository at this point in the history
  2. Address PR feedback

    stephentoub committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    5484061 View commit details
    Browse the repository at this point in the history
  3. Address PR feedback

    stephentoub committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    758fa86 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0588155 View commit details
    Browse the repository at this point in the history
  5. Address PR feedback

    stephentoub committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    ce36537 View commit details
    Browse the repository at this point in the history