Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JIT: fix issue with invalid operand size in OSR prolog on arm64 #68198

Merged
merged 1 commit into from
Apr 19, 2022

Conversation

AndyAyersMS
Copy link
Member

Need to use emitActualTypeSize for the operand size.

Fixes #68170.

Need to use `emitActualTypeSize` for the operand size.

Fixes dotnet#68170.
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 19, 2022
@ghost ghost assigned AndyAyersMS Apr 19, 2022
@ghost
Copy link

ghost commented Apr 19, 2022

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

Need to use emitActualTypeSize for the operand size.

Fixes #68170.

Author: AndyAyersMS
Assignees: -
Labels:

area-CodeGen-coreclr

Milestone: -

@AndyAyersMS
Copy link
Member Author

Non-OSR codegen doesn't hit this because it uses emitIns_R_S to load up enregistered stack args, which doesn't seem to do the same level of assertion checking (or something like that).

@jakobbotsch PTAL
cc @dotnet/jit-contrib

@AndyAyersMS
Copy link
Member Author

@dotnet/jit-contrib ping -- would like to get this in before we snap for p4.

Copy link
Member

@kunalspathak kunalspathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kunalspathak kunalspathak merged commit c8be3f3 into dotnet:main Apr 19, 2022
directhex pushed a commit to directhex/runtime that referenced this pull request Apr 21, 2022
…et#68198)

Need to use `emitActualTypeSize` for the operand size.

Fixes dotnet#68170.
@ghost ghost locked as resolved and limited conversation to collaborators May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assertion failed 'isValidGeneralDatasize(size)' during 'Generate code'
2 participants