JIT: fix patchpoint offset encoding #68202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
@jakobbotsch PTAL Current SPMI data (if there is any) will still "work". Will kick off a new ASP.NET collection once this lands. |
jakobbotsch
reviewed
Apr 19, 2022
src/coreclr/inc/patchpointinfo.h
Outdated
| } | ||
|
|
||
| void SetOffset(unsigned localNum, int offset) | ||
| { | ||
| m_offsetAndExposureData[localNum] = offset; | ||
| m_offsetAndExposureData[localNum] = (offset << OFFSET_SHIFT); |
There was a problem hiding this comment.
Seems like this will clear out the exposure bit.
There was a problem hiding this comment.
It's always been that way and calling SetIsExposed was optional. I'll rework this so they get set together.
We can now have Tier0 locals at byte offsets, so rework how the offset information is incoded in patchpoints to make this possible. Closes dotnet#68194.
|
Revised (and merged/force-pushed to fix up the committer email). |
72 tasks
jakobbotsch
approved these changes
Apr 19, 2022
directhex
pushed a commit
to directhex/runtime
that referenced
this pull request
Apr 21, 2022
We can now have Tier0 locals at byte offsets, so rework how the offset information is incoded in patchpoints to make this possible. Closes dotnet#68194.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can now have Tier0 locals at byte offsets, so rework how the offset
information is incoded in patchpoints to make this possible.
Closes #68194.