-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude all markdown files from triggering CI #68221
Conversation
Since 08/09/2021 it's now possible to use wild cards in exclusion patterns: https://docs.microsoft.com/en-us/azure/devops/release-notes/2021/sprint-192-update#support-for-wild-cards-in-path-filters. Fixing our exclude yml statements to ignore all markdown files in the repo and not just the ones under docs/.
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsSince 08/09/2021 it's now possible to use wild cards in exclusion patterns: https://docs.microsoft.com/en-us/azure/devops/release-notes/2021/sprint-192-update#support-for-wild-cards-in-path-filters. Fixing our exclude yml statements to ignore all markdown files in the repo and not just the ones under docs/.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This assumes that .md do not participate in any build steps. Seems like a safe assumption unless anyone knows otherwise.
Usually other text formats like .TXT are used as part of the build. I don't think a markdown file contributes in any way to the build and I don't think that we yet have any component in our build that validates markdown files. Ie nuget packages can include markdown files and they theoretically are an input to the Pack target but they aren't validated so it's likely not necessary to run CI for them. |
If I delete a .md that's such an input, could that break the build? If so then after this PR that break would no longer be detected. |
There appears to be some files whose extension end with It looks like the "md" stands for "metadata". I'm not familiar with the Mono build system, so I could not figure out if these are being used or not. |
Oh - such a simple check I didn't think to do. Here's the full list of problematic ones:
@akoeplinger do you know whether we can change their extensions, and if so, is there a matching code change to make? |
Yes that should be possible, I opened #68239 |
* Exclude all markdown files from triggering CI Since 08/09/2021 it's now possible to use wild cards in exclusion patterns: https://docs.microsoft.com/en-us/azure/devops/release-notes/2021/sprint-192-update#support-for-wild-cards-in-path-filters. Fixing our exclude yml statements to ignore all markdown files in the repo and not just the ones under docs/.
Since 08/09/2021 it's now possible to use wild cards in exclusion patterns: https://docs.microsoft.com/en-us/azure/devops/release-notes/2021/sprint-192-update#support-for-wild-cards-in-path-filters.
Fixing our exclude yml statements to ignore all markdown files in the repo and not just the ones under docs/.