-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If the user has < 65 cores and passes in an affinitized range for the 0th CPU group, if valid, honor it. #68283
Conversation
…0th CPU group, honor that passed in affinitized range if valid.
…U Groups are available
… there are < 65 cores and the user passed in a config related to the 0th CPU Group
Tagging subscribers to this area: @dotnet/gc Issue DetailsSummaryFor cases where the user is running on a machine with < 65 cores and has passed in a
NOTE: If both the Affinitized Range and the Affinitized Mask are passed, the Affinitized Mask is used if there are no CPU groups available on the machine. Implementation Details
|
…ask with CPU groups enabled, we error out since this case isn't valid
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks for getting it fixed!
@janvorli would you like to take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM modulo the nits.
Thanks for the feedback, @janvorli! I have incorporated them all and will merge these changes once the CI completes. |
Summary
For cases where the user is running on a machine with < 65 cores and has passed in a
GCHeapAffinitizeRanges
for just the 0th CPU group, apply the affinitized range rather than returning aCLR_E_GC_BAD_AFFINITY_CONFIG_FORMAT
. And fail if:NOTE: If both the Affinitized Range and the Affinitized Mask are passed, the Affinitized Mask is used if there are no CPU groups available on the machine.
Implementation Details