Update TestHandleCollector() test #68285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initialize local member in HandleCollector since it was the only one not initialized. Update test to wait for pending finalizers since that is when the HandleCollector API will trigger the GC.
|
Tagging subscribers to this area: @dotnet/interop-contrib Issue DetailsInitialize local member in Fixes #66571 /cc @dotnet/interop-contrib
|
jkoritzinsky
approved these changes
Apr 20, 2022
elinor-fung
approved these changes
Apr 20, 2022
...tem.Runtime.InteropServices.UnitTests/System/Runtime/InteropServices/HandleCollectorTests.cs
Outdated
Show resolved
Hide resolved
...tem.Runtime.InteropServices.UnitTests/System/Runtime/InteropServices/HandleCollectorTests.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Elinor Fung <elfung@microsoft.com>
|
Last commit was for comment updates. Skipping the full PR build. |
directhex
pushed a commit
to directhex/runtime
that referenced
this pull request
Apr 21, 2022
* Update TestHandleCollector() test Initialize local member in HandleCollector since it was the only one not initialized. Update test to wait for pending finalizers since that is when the HandleCollector API will trigger the GC. Co-authored-by: Elinor Fung <elfung@microsoft.com>
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initialize local member in
HandleCollectorsince it was the only one not initialized.Update test to wait for pending finalizers since that is when the
HandleCollectorAPI will trigger the GC.Fixes #66571
/cc @dotnet/interop-contrib