Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/7.0-preview4] Backport new Tar APIs #68337

Merged
merged 6 commits into from
Apr 22, 2022
Merged

[release/7.0-preview4] Backport new Tar APIs #68337

merged 6 commits into from
Apr 22, 2022

Conversation

carlossanlop
Copy link
Member

@carlossanlop carlossanlop commented Apr 21, 2022 •
edited
Loading

Backport of #67883 to release/7.0-preview4

@danmoseley @jeffhandley

Customer Impact

We added new APIs to provide Tar creation and reading support to .NET and we would like to start getting a usage signal on them.

Testing

The PR includes tests for all the features, including a good variety of edge cases.

Risk

Low. These new features live in their own new assembly and are not being consumed by other features.

@carlossanlop carlossanlop added the Servicing-consider Issue for next servicing release review label Apr 21, 2022
@carlossanlop carlossanlop added this to the 7.0.0 milestone Apr 21, 2022
@carlossanlop carlossanlop requested a review from adamsitnik April 21, 2022 16:28
@carlossanlop carlossanlop self-assigned this Apr 21, 2022
@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Apr 21, 2022

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #67883 to release/7.0-preview4

@danmoseley @jeffhandley

Customer Impact

We added new APIs to provide Tar creation and reading support to .NET and we would like to start getting a usage signal on them.

Testing

The PR includes tests for all the features, including a good variety of edge cases.

Risk

Low. These new features live in their own new assembly and are not being consumed by other features.

Author: carlossanlop
Assignees: carlossanlop
Labels:

Servicing-consider, area-Meta, new-api-needs-documentation
Milestone: 7.0.0

adamsitnik
adamsitnik approved these changes Apr 21, 2022
View reviewed changes
Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ghost
Copy link

ghost commented Apr 21, 2022

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #67883 to release/7.0-preview4

@danmoseley @jeffhandley

Customer Impact

We added new APIs to provide Tar creation and reading support to .NET and we would like to start getting a usage signal on them.

Testing

The PR includes tests for all the features, including a good variety of edge cases.

Risk

Low. These new features live in their own new assembly and are not being consumed by other features.

Author: carlossanlop
Assignees: carlossanlop
Labels:

Servicing-consider, area-System.IO, new-api-needs-documentation
Milestone: 7.0.0

jeffhandley
jeffhandley approved these changes Apr 21, 2022
View reviewed changes
Copy link
Member

@jeffhandley jeffhandley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm supportive of this getting backported into Preview 4. It's net-new functionality that is valuable to include in the preview, and the risk to the product is minimal.

@carlossanlop carlossanlop mentioned this pull request Apr 21, 2022
Merged
@leecow leecow added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Apr 21, 2022
@runfoapp runfoapp bot mentioned this pull request Apr 21, 2022
Closed
@carlossanlop
Copy link
Member Author

Included @danmoseley 's fix that blocked CI: #68361

@carlossanlop carlossanlop merged commit 083181f into dotnet:release/7.0-preview4 Apr 22, 2022
@carlossanlop carlossanlop deleted the BackportTar branch April 22, 2022 16:17
@ghost ghost locked as resolved and limited conversation to collaborators May 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ericstj ericstj ericstj left review comments

@jeffhandley jeffhandley jeffhandley approved these changes

@adamsitnik adamsitnik adamsitnik approved these changes

@ViktorHofer ViktorHofer ViktorHofer approved these changes

@danmoseley danmoseley Awaiting requested review from danmoseley

Assignees

@carlossanlop carlossanlop

Labels
area-System.Formats.Tar new-api-needs-documentation Servicing-approved Approved for servicing release
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
7 participants
@carlossanlop @jeffhandley @adamsitnik @danmoseley @ViktorHofer @ericstj @leecow