Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TODO-List-Cleanup] Implement fgSetTreeSeq via GenTreeVisitor #68383

Merged

Conversation

SingleAccretion
Copy link
Contributor

@SingleAccretion SingleAccretion commented Apr 22, 2022

Lets one more custom traversal go.

Also results in some ~0.17% fewer instructions according to PIN.

No diffs.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Apr 22, 2022
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 22, 2022
@ghost
Copy link

ghost commented Apr 22, 2022

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

Lets one more custom traversal go.

Also results in some ~0.17% fewer instructions executed according to PIN.

No diffs are expected.

Author: SingleAccretion
Assignees: -
Labels:

area-CodeGen-coreclr, community-contribution

Milestone: -

Lets one more custom traversal go.

Also results in some ~0.17% fewer instructions executed according to PIN.
@SingleAccretion SingleAccretion force-pushed the TODO-List-Cleanup-fgSetTreeSeq branch from 4888776 to 47310fb Compare April 22, 2022 14:01
@SingleAccretion SingleAccretion marked this pull request as ready for review April 22, 2022 16:54
@SingleAccretion
Copy link
Contributor Author

@dotnet/jit-contrib

@BruceForstall BruceForstall merged commit f5367a4 into dotnet:main Apr 22, 2022
@SingleAccretion SingleAccretion deleted the TODO-List-Cleanup-fgSetTreeSeq branch April 23, 2022 10:41
@SingleAccretion SingleAccretion mentioned this pull request Apr 26, 2022
@ghost ghost locked as resolved and limited conversation to collaborators May 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants