Improve the redundant branch optimization to handle more side effects #68447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
community-contribution
dotnet-issue-labeler
bot
added
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsTesting CI.
|
SingleAccretion
force-pushed
the
Redundant-Branches-SideEffects
branch
from
aa76fc2
to
41d240c
Compare
|
@dotnet/jit-contrib |
|
/azp run Antigen, Fuzzlyn |
|
Azure Pipelines successfully started running 2 pipeline(s). |
AndyAyersMS
approved these changes
Apr 25, 2022
AndyAyersMS
reviewed
Apr 25, 2022
| @@ -258,34 +262,41 @@ bool Compiler::optRedundantBranch(BasicBlock* const block) | |||
| return false; | |||
| } | |||
|
|
|||
| // Bail out if tree is has certain side effects | |||
| // Be conservative if there is an exception effect and we're in an EH region | |||
There was a problem hiding this comment.
Note to self: not sure why we don't check this condition earlier. No point in searching for dominating compares if we're just going to bail out here like this.
Antigen failures are also unrelated. |
@jakobbotsch can you look these over just to be sure? |
|
|
All Fuzzlyn/Antigen issues are known. |
|
@SingleAccretion, thanks again! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The redundant branches optimization was only handling exact-exception-sets matches, but we can do better by:
This change does just that, producing some nice diffs.