Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm-mt] fix build config logic error, and pthread_getschedparam initialization #68563

Merged
merged 3 commits into from
Apr 27, 2022

Conversation

lambdageek
Copy link
Member

Two followups for the initial merge PR.

  1. On Emscripten, pthread_getschedparam doesn't write to its output variables, so set them to good initial values
  2. The wasm CMakeLists.txt defaults DISABLE_THREADS to ON, so instead set it to off when MonoWasmThreads is true, and leave it at the default value (ie off) otherwise.

On Emscripten, pthreads_getschedparam doesn't write to its output
variables, so set them to good initial values
The wasm CMakeLists.txt defaults DISABLE_THREADS to ON, so instead set
it to _off_ when MonoWasmThreads is true, and leave it at the default
value (ie off) otherwise.
@ghost
Copy link

ghost commented Apr 26, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Two followups for the initial merge PR.

  1. On Emscripten, pthread_getschedparam doesn't write to its output variables, so set them to good initial values
  2. The wasm CMakeLists.txt defaults DISABLE_THREADS to ON, so instead set it to off when MonoWasmThreads is true, and leave it at the default value (ie off) otherwise.
Author: lambdageek
Assignees: lambdageek
Labels:

arch-wasm, area-Threading-mono

Milestone: -

@akoeplinger
Copy link
Member

On Emscripten, pthread_getschedparam doesn't write to its output variables, so set them to good initial values

Should we file an upstream issue for that? sounds unexpected

@lambdageek
Copy link
Member Author

Should we file an upstream issue for that? sounds unexpected

Maybe. I'm not sure they can make the function return some sensible values without having to implement a bunch of bookkeeping to try and match the POSIX spec.

@lambdageek lambdageek merged commit e48e107 into dotnet:main Apr 27, 2022
@ghost ghost locked as resolved and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-VM-threading-mono
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants