Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy propagate on LCL_FLDs #68592

Merged
merged 2 commits into from
May 11, 2022
Merged

Conversation

SingleAccretion
Copy link
Contributor

@SingleAccretion SingleAccretion commented Apr 27, 2022

Now that we check propagation legality using values of the underlying locations (as opposed to the nodes themselves), we can enable this small and simple CQ improvement.

Diffs.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Apr 27, 2022
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 27, 2022
@ghost
Copy link

ghost commented Apr 27, 2022

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

Now that we check propagation legality using values of the underlying locations (as opposed to the nodes themselves), we can enable this small and simple CQ improvement.

As usual, needed for future changes.

Author: SingleAccretion
Assignees: -
Labels:

area-CodeGen-coreclr, community-contribution

Milestone: -

@SingleAccretion SingleAccretion marked this pull request as ready for review April 27, 2022 15:16
@SingleAccretion
Copy link
Contributor Author

@dotnet/jit-contrib

@SingleAccretion SingleAccretion force-pushed the Copy-Prop-LclFld branch 2 times, most recently from 2c7e329 to 305b7c0 Compare May 8, 2022 14:18
A small and simple CQ improvement.

As usual, needed for future changes.
Copy link
Member

@jakobbotsch jakobbotsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jakobbotsch jakobbotsch merged commit 9158543 into dotnet:main May 11, 2022
@SingleAccretion SingleAccretion deleted the Copy-Prop-LclFld branch May 11, 2022 13:25
@ghost ghost locked as resolved and limited conversation to collaborators Jun 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants