Delete .NET Framework ildasm headers from test sources #68614
Conversation
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
|
||
| // Microsoft (R) .NET Framework IL Disassembler. Version 4.7.3071.0 | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed to the .NET Foundation under one or more agreements. |
There was a problem hiding this comment.
Is it intentional that you aren't adding the license header to the src/mono/mono/tests/* files?
There was a problem hiding this comment.
I do not know where these files came from originally. Adding the simple license headers may be actually wrong for them.
Also, nearly all files under src/mono/mono/tests/* are missing the license headers so it is also for consistency.
|
Failure look like caused by some recent infra change. Many PRs are red because of that. Tests pass, then helix script fails to access log file. e.g. https://helix.dot.net/api/2019-06-17/jobs/a55267d4-9f85-4033-8c34-48fbafc7c010/workitems/LibraryImportGenerator.Unit.Tests/console @alexperovich, @MattGal, could it be related to dotnet/arcade#8712? Helix SDK was updated 6 days ago: 2894f54. |
I don't think that one's it, but for @stephentoub's recent suggestion I just filed dotnet/arcade#9208. I understand the issue now and have deleted the bad 3 machines, and I will take a quick stab at hardening against this shortly (otherwise we'll get someone to work on it soon) |
|
All test failures are unrelated infrastructure issues. |
I just figured it might have been missed, I noticed it while checking in on this bug. I've merged a change that should make the infra issue not repro in the future. |
|
That one is #68393 |
ghost
locked as resolved and limited conversation to collaborators
No description provided.