Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JIT: Remove "promoted parameter" tailcall limitation #69034

Merged
merged 1 commit into from
May 12, 2022

Conversation

jakobbotsch
Copy link
Member

This is allowed for explicit tailcalls so it seems unlikely that there
are any actual problems with allowing this.

This is allowed for explicit tailcalls so it seems unlikely that there
are any actual problems with allowing this.
@ghost ghost assigned jakobbotsch May 8, 2022
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label May 8, 2022
@ghost
Copy link

ghost commented May 8, 2022

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

This is allowed for explicit tailcalls so it seems unlikely that there
are any actual problems with allowing this.

Author: jakobbotsch
Assignees: jakobbotsch
Labels:

area-CodeGen-coreclr

Milestone: -

@AndyAyersMS
Copy link
Member

Looks like DDARM64-147 is up to its old tricks.

@jakobbotsch
Copy link
Member Author

/azp run jitstress, libraries-jitstress

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@jakobbotsch
Copy link
Member Author

/azp run runtime-coreclr jitstress, runtime-coreclr libraries-jitstress

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@jakobbotsch
Copy link
Member Author

Failures are known.

@jakobbotsch jakobbotsch merged commit 6bac532 into dotnet:main May 12, 2022
@jakobbotsch jakobbotsch deleted the tailcall-with-promoted-params branch May 12, 2022 17:58
@ghost ghost locked as resolved and limited conversation to collaborators Jun 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants