Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip unnecessary ALPN processing on Windows #69103

Merged
merged 1 commit into from
May 10, 2022
Merged

skip unnecessary ALPN processing on Windows #69103

merged 1 commit into from
May 10, 2022

Conversation

wfurt
Copy link
Member

@wfurt wfurt commented May 10, 2022

The InitializeSecurityContext and AcceptSecurityContext methods can be called multiple times during handshake. But the ALPN is needed only on the first call (when context is null) e.g. ClientHello and ServerHello.

contributes to #68951

@wfurt wfurt requested a review from a team May 10, 2022 05:22
@wfurt wfurt self-assigned this May 10, 2022
@ghost
Copy link

ghost commented May 10, 2022

Tagging subscribers to this area: @dotnet/ncl, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

The InitializeSecurityContext and AcceptSecurityContext methods can be called multiple times during handshake. But the ALPN is needed only on the first call (when context is null) e.g. ClientHello and ServerHello.

contributes to #68951

Author: wfurt
Assignees: wfurt
Labels:

area-System.Net.Security, os-windows

Milestone: -

@wfurt wfurt merged commit 9291a78 into dotnet:main May 10, 2022
@wfurt wfurt deleted the alpn2 branch May 10, 2022 16:42
@ghost ghost locked as resolved and limited conversation to collaborators Jun 9, 2022
@karelz karelz added this to the 7.0.0 milestone Jul 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants