Add the repro case for race condition in revisit_written_pages as a GC test case #69496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/gc |
|
Does it also need to be added to a CI config, or is the expectation that this is run manually? |
|
I think Peter ran this standalone manually in a loop. I'm fine with keeping this in the stress dir even though this is not added to the testmix config as we will be doing work on stress in the near future anyway (I suspect lots of tests will be removed/changed/etc with new tests added). |
Maoni0
approved these changes
May 18, 2022
danmoseley
reviewed
May 18, 2022
| { | ||
| ta[i].Join(); | ||
| } | ||
| double elapsed = 0.001*(System.Environment.TickCount - startTick); |
There was a problem hiding this comment.
is 0.001 right? There are 10 million ticks in a second
There was a problem hiding this comment.
Environment.TickCount returns milliseconds.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was github issue #68443 (#68443).