Dispose of processes launched in host tests #69625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov Issue DetailsThere have been intermittent failures where the host tests fail to clean up with
This change makes the This also switches some of the tests to use the
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There have been intermittent failures where the host tests fail to clean up with
UnauthorizedAccessExceptionfor an executable we launch. Examples:It seems the host test don't dispose any of the processes they launch. This change makes the
Command.WaitForExithelper dispose of the underlying process. All the tests should go through this. We could also makeCommanddisposable, but that makes the usage in all the tests more awkward with the current pattern of chained invokes/assertions.This also switches some of the tests to use the
TestArtifacthelper class for cleaning up a test directory.