Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable some HTTP3 tests #69789

Merged
merged 2 commits into from
May 25, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,6 @@ public async Task ClientSettingsReceived_Success(int headerSizeLimit)
}

[Theory]
[ActiveIssue("https://github.com/dotnet/runtime/issues/55957")]
[InlineData(10)]
[InlineData(100)]
[InlineData(1000)]
Expand Down Expand Up @@ -111,7 +110,6 @@ public async Task SendMoreThanStreamLimitRequests_Succeeds(int streamLimit)
}

[Theory]
[ActiveIssue("https://github.com/dotnet/runtime/issues/56000")]
[InlineData(10)]
[InlineData(100)]
[InlineData(1000)]
Expand Down Expand Up @@ -757,7 +755,6 @@ public async Task ResponseCancellation_ServerReceivesCancellation(CancellationTy
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/56265")]
public async Task ResponseCancellation_BothCancellationTokenAndDispose_Success()
{
if (UseQuicImplementationProvider != QuicImplementationProviders.MsQuic)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ public void CreateAndDestroyManyClients(int numClients)
}

[ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsMsQuicSupported))]
[Collection(nameof(DisableParallelization))]
public sealed class SocketsHttpHandler_HttpClientMiniStress_Http3_MsQuic : HttpClientMiniStress
{
public SocketsHttpHandler_HttpClientMiniStress_Http3_MsQuic(ITestOutputHelper output) : base(output) { }
Expand Down Expand Up @@ -85,7 +86,7 @@ await LoopbackServer.CreateServerAsync(async (server, url) =>
await server.AcceptConnectionAsync(async connection =>
{
byte[] postData = new byte[numBytes];
while (!string.IsNullOrEmpty(await connection.ReadLineAsync().ConfigureAwait(false)));
while (!string.IsNullOrEmpty(await connection.ReadLineAsync().ConfigureAwait(false))) ;
Assert.Equal(numBytes, await connection.ReadBlockAsync(postData, 0, numBytes));

await connection.WriteStringAsync(responseText).ConfigureAwait(false);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ public async Task ZeroByteRead_IssuesZeroByteReadOnUnderlyingStream(StreamConfor
using Stream clientStream = response.Content.ReadAsStream();
Assert.False(sawZeroByteRead.Task.IsCompleted);

Task<int> zeroByteReadTask = Task.Run(() => StreamConformanceTests.ReadAsync(readMode, clientStream, Array.Empty<byte>(), 0, 0, CancellationToken.None) );
Task<int> zeroByteReadTask = Task.Run(() => StreamConformanceTests.ReadAsync(readMode, clientStream, Array.Empty<byte>(), 0, 0, CancellationToken.None));
Assert.False(zeroByteReadTask.IsCompleted);

// The zero-byte read should block until data is actually available
Expand Down Expand Up @@ -210,6 +210,7 @@ public Http2ResponseStreamZeroByteReadTest(ITestOutputHelper output) : base(outp
}

[ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsMsQuicSupported))]
[Collection(nameof(DisableParallelization))]
public sealed class Http3ResponseStreamZeroByteReadTest_MsQuic : ResponseStreamZeroByteReadTestBase
{
public Http3ResponseStreamZeroByteReadTest_MsQuic(ITestOutputHelper output) : base(output) { }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -769,6 +769,7 @@ public TelemetryTest_Http20(ITestOutputHelper output) : base(output) { }
}

[ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsMsQuicSupported))]
[Collection(nameof(DisableParallelization))]
public sealed class TelemetryTest_Http30_MsQuic : TelemetryTest
{
protected override Version UseVersion => HttpVersion.Version30;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -288,6 +288,8 @@ public QuicConnectionTests_MockProvider(ITestOutputHelper output) : base(output)
}

[ConditionalClass(typeof(QuicTestBase<MsQuicProviderFactory>), nameof(QuicTestBase<MsQuicProviderFactory>.IsSupported))]
[Collection(nameof(DisableParallelization))]

public sealed class QuicConnectionTests_MsQuicProvider : QuicConnectionTests<MsQuicProviderFactory>
{
public QuicConnectionTests_MsQuicProvider(ITestOutputHelper output) : base(output) { }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ public QuicListenerTests_MockProvider(ITestOutputHelper output) : base(output) {
}

[ConditionalClass(typeof(QuicTestBase<MsQuicProviderFactory>), nameof(QuicTestBase<MsQuicProviderFactory>.IsSupported))]
[Collection(nameof(DisableParallelization))]
public sealed class QuicListenerTests_MsQuicProvider : QuicListenerTests<MsQuicProviderFactory>
{
public QuicListenerTests_MsQuicProvider(ITestOutputHelper output) : base(output) { }
Expand Down